Skip to content

Commit

Permalink
Only change home files ownership for --rebuild mode
Browse files Browse the repository at this point in the history
Changing ownership of the entire $HOME directory tree is sometimes an
expensive task and a no-op anyway because there's typically no reason
for files with the wrong ownership to appear. Let's stop doing it to
make the subsequent mock --chroot calls faster and more predictable.

In other words, if users want to shoot themselves in the foot and give
the files in '/builddir' away (e.g., using "privileged" --chroot calls),
Mock will no longer fix the ownership problems.  We only continue to fix
the permissions for the --rebuild mode, which shouldn't be expensive
(because there are pre-build cleanups) and seems important enough to
risk changing.

Suggested by @kdudka in rpm-software-management#1257.
  • Loading branch information
praiskup authored and xsuchy committed Feb 6, 2024
1 parent 27dde5d commit db64d46
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion mock/py/mockbuild/buildroot.py
Original file line number Diff line number Diff line change
Expand Up @@ -348,7 +348,8 @@ def _init(self, prebuild):

# Change owner of homdir tree if the root of it not owned
# by the current user
self.chown_home_dir()
if prebuild:
self.chown_home_dir()

# mark the buildroot as initialized
file_util.touch(self.make_chroot_path('.initialized'))
Expand Down

0 comments on commit db64d46

Please sign in to comment.