server: make pools with just on_demand_tags: and no tags: work #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FrostyX
approved these changes
Mar 13, 2024
- We correctly assert that one of `tags_on_demand: []` isn't specified
also in the set of `tags: []`, which would otherwise break the logic
miserably.
- The `Pool.tags` array is not modified ("enlarged") by the
`tags_on_demand: []`, just to logically separate it.
- If either `Pool.tags` or `Pool.tags_on_demand` is unspecified, the
system still can continue working (with default value []).
- Documentation fix s/on_demand_tags/tags_on_demand/.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.