Agent spawner configurations should be accessible #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... as attributes. Signed-off-by: Siteshwar Vashisht <[email protected]>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| # expects configurations to be attributes rather than key/value pairs. | ||
| # This class works around this requirement. | ||
| # Thanks to https://stackoverflow.com/a/14620633 | ||
| class AttrDict(dict): |
Check warning
Code scanning / vcs-diff-lint
get_config.AttrDict: Missing class docstring Warning
| # Thanks to https://stackoverflow.com/a/14620633 | ||
| class AttrDict(dict): | ||
| def __init__(self, *args, **kwargs): | ||
| super(AttrDict, self).__init__(*args, **kwargs) |
Check warning
Code scanning / vcs-diff-lint
get_config.AttrDict.init: Consider using Python 3 style super() without arguments Warning
praiskup
added a commit
to praiskup/copr
that referenced
this pull request
Mar 14, 2024
The check like:
if hasattr(opts, "redis_port"):
kwargs["port"] = opts.redis_port
Can not work with dict() objects. The hasattr() actually doesn't work
this way.
See: praiskup/resalloc#154
|
Very good catch, thank you! I think we should do fedora-copr/copr#3186 instead, to make copr-common accept dictionary objects. OTOH, I don't see any potential problems if this patch is merged; at least if we are in hurry for the fix. |
praiskup
added a commit
to fedora-copr/copr
that referenced
this pull request
Mar 15, 2024
The check like:
if hasattr(opts, "redis_port"):
kwargs["port"] = opts.redis_port
Can not work with dict() objects. The hasattr() actually doesn't work
this way.
See: praiskup/resalloc#154
praiskup
added a commit
that referenced
this pull request
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... as attributes.