agent-spawner: base64 encoding one more time #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
praiskup
force-pushed
the
b64-encode-take-2
branch
from
16fd013
to
2ea8ff7
Compare
praiskup
force-pushed
the
b64-encode-take-2
branch
from
2ea8ff7
to
14b3258
Compare
siteshwar
reviewed
Mar 15, 2024
| # The ticket.output is bytes(), and we don't plan to touch the data at | ||
| # all, we are just going to "forward" the data base64 encoded to our | ||
| # hook scripts. Encode it now, and never change again. | ||
| return base64.b64encode(ticket.output.data).decode("ascii") |
There was a problem hiding this comment.
Why do we need decode() here?
There was a problem hiding this comment.
b64encode returns bytes, yes
|
I have not tested this change, but if it works. Please merge. EDIT: I managed to test it later and it works. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The base64 encoding is worth doing on the dispatcher side, and store strings to Redis, instead of decoding and encoding it once more in worker (see #155).
Fixes: #155