fix: github app install wrong folder

praswicaksono · Nov 16, 2024 · 0c059d6 · 0c059d6
1 parent d9ef74c
commit 0c059d6
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/src/Command/InstallCommand.php b/src/Command/InstallCommand.php
@@ -226,7 +226,7 @@ private function downloadFromGithub(string $namespace, string $url): \Generator
             mkdir -p -m755 {$dir}
             curl -L --progress-bar {$githubUrl} -o '{$dir}/{$appName}.zip'
             unzip {$dir}/{$appName}.zip -d {$dir}
-            mv {$dir}/{$appName}-{$tag} {$cwd}
+            mv {$dir}/apps-{$appName}-{$tag} {$cwd}
             chmod 755 {$cwd}
             find {$cwd} -type d -exec chmod 755 {} \; && find {$cwd} -type f -exec chmod 644 {} \;
             rm -f {$cwd}.zip

diff --git a/src/Command/ServiceDelCommand.php b/src/Command/ServiceDelCommand.php
@@ -74,6 +74,8 @@ private function deleteService(string $namespace, string $name): \Generator
                 $this->io->success('Service has been deleted.');
 
                 if (array_key_exists($name, $apps)) {
+                    $appDir = getenv('HOME') . "/.mager/apps/{$namespace}/{$name}";
+                    yield "rm -rf {$appDir}";
                     unset($apps[$name]);
                     $this->config->set("{$namespace}.apps", $apps);
                     $this->config->save();