Issue 557: Many Pravega Spec parameters are still not updatable at runtime #561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: anishakj <[email protected]>
Signed-off-by: anishakj <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #561 +/- ##
==========================================
+ Coverage 71.99% 72.06% +0.06%
==========================================
Files 15 15
Lines 3682 3694 +12
==========================================
+ Hits 2651 2662 +11
+ Misses 911 908 -3
- Partials 120 124 +4
Continue to review full report at Codecov.
|
Signed-off-by: anishakj <[email protected]>
SrishT
reviewed
Jul 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change log description
Currently many parameters belonging to sts and deployment are not updatable at runtime. eg; Resources
Purpose of the change
Fixes #557
What the code does
Made changes for updating statefulset and deployment if there are any changes to them
How to verify it
Modified pravega cluster fields like resources and verified that sts and deployments are getting updated and pods are getting restarted.