-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 40: Serializers Implementation for Schema Registry #41
Changes from 82 commits
76d99a3
b634867
a0876cc
05cc270
8ee1fef
193776d
600ff74
be5115e
409c106
88af2e7
b1a8894
1961ba1
58e7f65
026b725
7027d88
4be3f40
cc223ec
a0a2db7
8a8c872
3f64c11
fba77f6
a449b4b
22a0a0d
9a50464
8cc3091
d063e7c
5a7d639
a9cca3a
0b6230a
911f793
7ff74af
c9f9d3f
5d91574
7c30b4f
98a9c6b
dcff47c
28660e4
53b8988
8e2c704
ce1aa98
151b808
bffd0f7
26e34f1
049fb6d
910f870
d690a21
a44c0fb
a82ee56
7b34571
48da360
72919bb
48e54e9
7c9ba8e
214ab54
2241865
456e6bd
9741bd5
6f7f4d5
87c9ebc
f8fd8ad
c98ee7b
c3789ca
32933ba
d8b0675
322d3c0
a586f4f
cdc0c0c
8693357
223df77
8c69b3f
572f34f
cf82e07
c4a732b
5daaeb4
eedee88
b63a8a4
23e6470
4925759
1dafddb
53b8f9c
a744198
c6a02c8
bf0dfb4
d70ba7e
4117557
0f770fa
9823974
7ee6fe0
ff47289
6c3fd87
2d6711d
ade09af
9cbaaae
c0e57be
174c4e6
fe0974f
d464b6b
9137aa6
ed740ea
a8fb0dd
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,45 @@ | ||
/** | ||
* Copyright (c) Dell Inc., or its subsidiaries. All Rights Reserved. | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
*/ | ||
package io.pravega.schemaregistry.common; | ||
|
||
public class NameUtil { | ||
/** | ||
* Extracts the name from the fully qualified type name. Name represents the last token after ".". | ||
* If the qualified name does not contain "." then the name is same as qualified name. | ||
shiveshr marked this conversation as resolved.
Show resolved
Hide resolved
|
||
* | ||
* Example: io.pravega.MyObject will return MyObject | ||
* Example: MyObject will return MyObject | ||
* | ||
* @param qualifiedName qualified name to extract name from. | ||
* @return extracted name. | ||
*/ | ||
public static String extractName(String qualifiedName) { | ||
int nameStart = qualifiedName.lastIndexOf("."); | ||
return qualifiedName.substring(nameStart + 1); | ||
} | ||
|
||
/** | ||
* Extracts name and the prefix qualifier before the name. Name represents the last token after ".". | ||
* Qualifier is the prefix before the name. | ||
* If the qualified name does not contain "." then the name is same as qualified name and qualifier is empty string. | ||
* | ||
* Example: io.pravega.MyObject will return ["MyObject", "io.pravega"] | ||
* Example: MyObject will return ["MyObject", ""] | ||
* | ||
* @param qualifiedName qualified name to extract tokens from. | ||
* @return an array containing name at index 0 and qualifier at index 1. | ||
*/ | ||
public static String[] extractNameAndQualifier(String qualifiedName) { | ||
int nameStart = qualifiedName.lastIndexOf("."); | ||
String name = qualifiedName.substring(nameStart + 1); | ||
String pckg = nameStart < 0 ? "" : qualifiedName.substring(0, nameStart); | ||
return new String[]{name, pckg}; | ||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,37 @@ | ||
/** | ||
* Copyright (c) Dell Inc., or its subsidiaries. All Rights Reserved. | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
*/ | ||
package io.pravega.schemaregistry; | ||
|
||
import com.google.common.base.Preconditions; | ||
import io.pravega.shared.NameUtils; | ||
|
||
/** | ||
* Defines strategies for generating groupId for stream. | ||
* Currently there is only one naming strategy that uses streams fully qualified scoped stream name. | ||
*/ | ||
public class GroupIdGenerator { | ||
private GroupIdGenerator() { | ||
} | ||
|
||
public static String getGroupId(Scheme scheme, String... args) { | ||
shiveshr marked this conversation as resolved.
Show resolved
Hide resolved
|
||
switch (scheme) { | ||
case QualifiedStreamName: | ||
Preconditions.checkNotNull(args); | ||
Preconditions.checkArgument(args.length == 2, "Both scope and stream name should be supplied."); | ||
return NameUtils.getScopedStreamName(args[0], args[1]); | ||
default: | ||
throw new IllegalArgumentException("Unknown Group id generation schema."); | ||
} | ||
} | ||
|
||
public enum Scheme { | ||
QualifiedStreamName, | ||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,51 @@ | ||
/** | ||
* Copyright (c) Dell Inc., or its subsidiaries. All Rights Reserved. | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
*/ | ||
package io.pravega.schemaregistry.codec; | ||
|
||
import io.pravega.schemaregistry.contract.data.CodecType; | ||
import io.pravega.schemaregistry.contract.data.EncodingInfo; | ||
|
||
import java.io.IOException; | ||
import java.nio.ByteBuffer; | ||
|
||
/** | ||
* Codec interface that defines methods to encode and decoder data for a given codec type. | ||
*/ | ||
public interface Codec { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should this extend There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. No, its not a serializer but a transformer of bytes. Extending the Serializer interface with type byteBuffer will be an unnecessary semantic overload. |
||
/** | ||
* Codec Type object that contains a string name identifying the Codec Type. | ||
* This name should be same as the codecType that is registered for the group in schema registry service. | ||
* The serializers will use this codec to encode the data and deserializers will find | ||
* the decoder for the encoded data from {@link EncodingInfo#getCodecType()} | ||
* | ||
* @return Name of the codec. | ||
*/ | ||
CodecType getCodecType(); | ||
|
||
/** | ||
* Implementation should encode the remaining bytes in the buffer and return a new ByteBuffer that includes | ||
* the encoded data at its current position. | ||
* | ||
* @param data ByteBuffer to encode. | ||
* @return encoded ByteBuffer with position set to the start of encoded data. | ||
* @throws IOException IOException can be thrown while reading from or writing to byte buffers. | ||
*/ | ||
ByteBuffer encode(ByteBuffer data) throws IOException; | ||
|
||
/** | ||
* Implementation should decode the remaining bytes in the buffer and return a new ByteBuffer that includes | ||
* the decoded data at its current position. | ||
* | ||
* @param data encoded ByteBuffer to decode. | ||
* @return decoded ByteBuffer with position set to the start of decoded data. | ||
* @throws IOException can be thrown while reading from or writing to byte buffers. | ||
*/ | ||
ByteBuffer decode(ByteBuffer data) throws IOException; | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,141 @@ | ||
/** | ||
* Copyright (c) Dell Inc., or its subsidiaries. All Rights Reserved. | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
*/ | ||
package io.pravega.schemaregistry.schemas; | ||
|
||
import com.google.common.base.Charsets; | ||
import com.google.common.base.Preconditions; | ||
import com.google.common.collect.ImmutableMap; | ||
import io.pravega.schemaregistry.contract.data.SchemaInfo; | ||
import io.pravega.schemaregistry.contract.data.SerializationFormat; | ||
import lombok.Getter; | ||
import org.apache.avro.generic.GenericRecord; | ||
import org.apache.avro.reflect.ReflectData; | ||
import org.apache.avro.specific.SpecificData; | ||
import org.apache.avro.specific.SpecificRecordBase; | ||
|
||
import java.nio.ByteBuffer; | ||
|
||
/** | ||
* Container class for Avro Schema. | ||
* | ||
* @param <T> Type of element. | ||
*/ | ||
public class AvroSchema<T> implements Schema<T> { | ||
@Getter | ||
private final org.apache.avro.Schema schema; | ||
private final SchemaInfo schemaInfo; | ||
@Getter | ||
private final Class<T> tClass; | ||
|
||
private AvroSchema(org.apache.avro.Schema schema, Class<T> tClass) { | ||
this.schema = schema; | ||
this.schemaInfo = new SchemaInfo(schema.getFullName(), | ||
SerializationFormat.Avro, getSchemaBytes(), ImmutableMap.of()); | ||
this.tClass = tClass; | ||
} | ||
|
||
private AvroSchema(SchemaInfo schemaInfo) { | ||
String schemaString = new String(schemaInfo.getSchemaData().array(), Charsets.UTF_8); | ||
this.schema = new org.apache.avro.Schema.Parser().parse(schemaString); | ||
this.schemaInfo = schemaInfo; | ||
this.tClass = null; | ||
} | ||
|
||
/** | ||
* Method to create a typed AvroSchema for the given class. It extracts the avro schema from the class. | ||
* For Avro generated classes, the schema is retrieved from the class. | ||
* For POJOs the schema is extracted using avro's {@link ReflectData}. | ||
* | ||
* @param tClass Class whose object's schema is used. | ||
* @param <T> Type of the Java class. | ||
* @return {@link AvroSchema} with generic type T that extracts and captures the avro schema. | ||
*/ | ||
public static <T> AvroSchema<T> of(Class<T> tClass) { | ||
org.apache.avro.Schema schema; | ||
if (SpecificRecordBase.class.isAssignableFrom(tClass)) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There appears to already be a method for such a class. We should probably differentiate these methods by name with one for the reflection and one for the specificRecord case. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. That other method creates the Schema of type This matters for multi type handling where we want the schema to be of the common base class as serializer/deserializer is created with that specific type. |
||
schema = SpecificData.get().getSchema(tClass); | ||
} else { | ||
schema = ReflectData.get().getSchema(tClass); | ||
} | ||
return new AvroSchema<>(schema, tClass); | ||
} | ||
|
||
/** | ||
* Method to create a typed AvroSchema of type {@link Object} from the given schema. | ||
* This schema can be used to express any non record schema. | ||
* | ||
* @param schema Schema to use. | ||
* @return Returns an AvroSchema with {@link GenericRecord} type. | ||
*/ | ||
public static AvroSchema<Object> of(org.apache.avro.Schema schema) { | ||
return new AvroSchema<>(schema, Object.class); | ||
} | ||
|
||
/** | ||
* Method to create a typed AvroSchema of type {@link GenericRecord} from the given schema. | ||
* | ||
* @param schema Schema to use. | ||
* @return Returns an AvroSchema with {@link GenericRecord} type. | ||
*/ | ||
public static AvroSchema<GenericRecord> ofRecord(org.apache.avro.Schema schema) { | ||
shrids marked this conversation as resolved.
Show resolved
Hide resolved
|
||
Preconditions.checkArgument(schema.getType().equals(org.apache.avro.Schema.Type.RECORD)); | ||
return new AvroSchema<>(schema, GenericRecord.class); | ||
} | ||
|
||
/** | ||
* It is same as {@link #of(Class)} except that it generates an AvroSchema typed as T. | ||
* | ||
* This is useful for supplying a map of Avro schemas for multiplexed serializers and deserializers. | ||
* | ||
* @param tDerived Class whose schema should be used. | ||
* @param tBase Base class for the typed AvroSchema object. | ||
* @param <T> Type of base class. | ||
* @return Returns an AvroSchema with T type. | ||
*/ | ||
public static <T> AvroSchema<T> ofBaseType(Class<? extends T> tDerived, Class<T> tBase) { | ||
Preconditions.checkArgument(tBase.isAssignableFrom(tDerived)); | ||
|
||
return new AvroSchema<>(ReflectData.get().getSchema(tDerived), tBase); | ||
} | ||
|
||
/** | ||
* It is same as {@link #of(Class)} except that it generates an AvroSchema typed as {@link SpecificRecordBase}. | ||
* | ||
* This is useful for supplying a map of Avro schemas for multiplexed serializers and deserializers. | ||
* | ||
* @param tClass Class whose schema should be used. | ||
* @param <T> Type of class whose schema is to be used. | ||
* @return Returns an AvroSchema with {@link SpecificRecordBase} type. | ||
*/ | ||
public static <T extends SpecificRecordBase> AvroSchema<SpecificRecordBase> ofSpecificRecord(Class<T> tClass) { | ||
Preconditions.checkArgument(SpecificRecordBase.class.isAssignableFrom(tClass)); | ||
|
||
return new AvroSchema<>(SpecificData.get().getSchema(tClass), SpecificRecordBase.class); | ||
} | ||
|
||
/** | ||
* Method to create a typed AvroSchema of type {@link GenericRecord} from schema info. | ||
* | ||
* @param schemaInfo Schema info object that has schema data in binary form. | ||
* @return Returns an AvroSchema with {@link GenericRecord} type. | ||
*/ | ||
public static AvroSchema<Object> from(SchemaInfo schemaInfo) { | ||
return new AvroSchema<>(schemaInfo); | ||
} | ||
|
||
private ByteBuffer getSchemaBytes() { | ||
return ByteBuffer.wrap(schema.toString().getBytes(Charsets.UTF_8)); | ||
} | ||
|
||
@Override | ||
public SchemaInfo getSchemaInfo() { | ||
return schemaInfo; | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These should probably be separated into individual targets so that users don't need to depend on more than what they actually need.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Created issue #45 to tackle this later as it would require considerable refactoring at this time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will it require a change to
SerializerFactory
? I'm concerned that this could be an API change, and even though we are making this beta, this is an anticipated change, it is not something that we learned later. If we can do it now, I'd say it is better.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The way i am thinking is as follows:
have format specific serializers implemented in format specific module.
So one for protobuf, one for json, one for avro. Each such module will have a factory with only serializers/deserializers for that format.
Then we will have a consolidated one, which is this library and factory class. This is because here we have serializers which are multi format.
So this way users can take dependency on one common module (all type 1 apps that want to work for multiple formats can depend on this one module).
So the user contract, which is the SerializerFactory, doesnt change.
Only the serializer implementations would move internal to their respective modules and this base module would take dependence on those.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If applications are supposed to use the specific modules, why do we need the base module? If I understand correctly, the base module is a level of indirection to the specific modules.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it serves as two purposes:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine with this direction, @tkaitchuck needs to resolve this thread if he is satisfied.