fix: Use HELM 3 best practices for CRDs #490
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 85.12% // Head: 85.12% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #490 +/- ##
=======================================
Coverage 85.12% 85.12%
=======================================
Files 12 12
Lines 1613 1613
=======================================
Hits 1373 1373
Misses 155 155
Partials 85 85 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Current logic uses helm2 style conditions for CRDs which may or may not be installed prior to use when included in a subchart or as part of CD. Simply removing the if condition from the CRD sync step in the make file allows the helm3 supported method of opt out ``--skip-crds`` Signed-off-by: Ryan Faircloth <[email protected]>
|
Note: Codecov is reporting a change in a file no present in the branch |
amuraru
approved these changes
Jul 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change log description
Current logic uses helm2 style conditions for CRDs which may or may not be installed prior to use when included in a subchart or as part of CD. Simply removing the if condition from the CRD sync step in the make file allows the helm3 supported method of opt out
--skip-crdsPurpose of the change
Implement CRD best practices for helm3
What the code does
Remove if/else logic as this is now built into helm3
How to verify it
On a new cluster manually install CRDs then install chart using --skip-crds flag (confirm working)
On a new cluster do not manuall install CRDs then install without flag and confirm working