Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the default snapCount configuration mismatch the comment. #564

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sangheee
Copy link

@sangheee sangheee commented Jul 3, 2023

Change log description

The default value of snapCount that the comment says is 100,000.
But the actual value is set at 10,000.
I corrected this mismatch between them.

Purpose of the change

None

What the code does

How to verify it

The default value of snapCount that the comment says is 100,000.
But the actual value is set 10,000.
I corrected this mismatch between them.
@codecov
Copy link

codecov bot commented Jul 3, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (9d283c2) 85.12% compared to head (b9aaa6d) 85.12%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #564   +/-   ##
=======================================
  Coverage   85.12%   85.12%           
=======================================
  Files          12       12           
  Lines        1613     1613           
=======================================
  Hits         1373     1373           
  Misses        155      155           
  Partials       85       85           
Impacted Files Coverage Δ
api/v1beta1/zookeepercluster_types.go 98.80% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sangheee sangheee changed the title the default snapCount configuration doesn't mismatch the comment. the default snapCount configuration mismatch the comment. Jul 5, 2023
@anishakj
Copy link
Contributor

@sangheee Here the comment needs to be corrected, default snapshot count is 10000 https://zookeeper.apache.org/doc/r3.1.2/zookeeperAdmin.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants