Scope approvals to documentId (#49)

.changeset/giant-otters-whisper.md

@@ -0,0 +1,5 @@
+---
+'chrome-extension': patch
+---
+
+scope init to documentId

apps/extension/src/content-scripts/injected-connection-port.ts

@@ -1,16 +1,44 @@
-import { PraxMessage } from './message-event';
 import { CRSessionClient } from '@penumbra-zone/transport-chrome/session-client';
 import { PraxConnection } from '../message/prax';
+import { PraxMessage } from './message-event';
+
+// this script will init the page session upon instruction from an extension
+// worker. init does not arrive in direct response to an emitted message, it is
+// independent.
+
+// handler to listen for init command for this document
+const initOnce = (
+  req: unknown,
+  // content script message handlers are activated only by another
+  // script in the same extension using chrome.tabs.sendMessage
+  sender: chrome.runtime.MessageSender,
+  // this handler will only ever send an empty response
+  emptyResponse: (no?: never) => void,
+) => {
+  if (req !== PraxConnection.Init) {
+    // boolean return in handlers signals intent to respond
+    return false;
+  }
 
-// this inits the session client that transports messages on the DOM channel through the Chrome runtime
-const initOnce = (req: unknown, _sender: chrome.runtime.MessageSender, respond: () => void) => {
-  if (req !== PraxConnection.Init) return false;
   chrome.runtime.onMessage.removeListener(initOnce);
 
+  if (sender.id !== PRAX) {
+    throw new Error(`Unexpected sender ${sender.id}`);
+  }
+
+  // create session, post port to window where the injected global can catch it.
   const port = CRSessionClient.init(PRAX);
   window.postMessage({ [PRAX]: port } satisfies PraxMessage<MessagePort>, '/', [port]);
-  respond();
+
+  // handler is done
+  emptyResponse();
+
+  // boolean return in handlers signals intent to respond
   return true;
 };
 
+// attach handler
 chrome.runtime.onMessage.addListener(initOnce);
+
+// announce
+void chrome.runtime.sendMessage(PraxConnection.Init);

apps/extension/src/content-scripts/injected-penumbra-global.ts

@@ -52,19 +52,12 @@ const requestResponseListener = (msg: MessageEvent<unknown>) => {
   if (msg.origin === window.origin) {
     if (isPraxFailureMessageEvent(msg)) {
       // @ts-expect-error - ts can't understand the injected string
-      const status = msg.data[PRAX] as PraxConnection;
+      const status: unknown = msg.data[PRAX];
       const failure = new Error('Connection request failed');
-      switch (status) {
-        case PraxConnection.Denied:
-          failure.cause = PenumbraRequestFailure.Denied;
-          break;
-        case PraxConnection.NeedsLogin:
-          failure.cause = PenumbraRequestFailure.NeedsLogin;
-          break;
-        default:
-          failure.cause = 'Unknown';
-          break;
-      }
+      failure.cause =
+        typeof status === 'string' && status in PenumbraRequestFailure
+          ? status
+          : `Unknown failure: ${String(status)}`;
       request.reject(failure);
     }
   }