fix(extension): #107: allow http for localhost #153
Conversation
…or-localhost # Conflicts: # apps/extension/public/manifest.json
|
| @@ -16,12 +16,12 @@ | |||
| }, | |||
| "content_scripts": [ | |||
| { | |||
| "matches": ["https://*/*"], | |||
| "matches": ["https://*/*", "http://localhost/*"], | |||
There was a problem hiding this comment.
this line, instead of the previously used one, must work correctly according to the docs: https://developer.chrome.com/docs/extensions/develop/concepts/match-patterns#special
There was a problem hiding this comment.
Just checked a test upload, it works 👍
| @@ -16,12 +16,12 @@ | |||
| }, | |||
| "content_scripts": [ | |||
| { | |||
| "matches": ["https://*/*"], | |||
| "matches": ["https://*/*", "http://localhost/*"], | |||
There was a problem hiding this comment.
Just checked a test upload, it works 👍
| if ( | ||
| !( | ||
| parsedOrigin.protocol in ValidProtocol || | ||
| (globalThis.__DEV__ && isHttpLocalhost(parsedOrigin)) | ||
| ) | ||
| ) { |
There was a problem hiding this comment.
todo: we should have a test for this in validate.test.ts. Also, could you check that test suite to ensure we've covered all cases for this function?
There was a problem hiding this comment.
@grod220 thanks for pointing this out. I should pay more attention to the tests
| if ( | ||
| !( | ||
| parsedOrigin.protocol in ValidProtocol || | ||
| (globalThis.__DEV__ && isHttpLocalhost(parsedOrigin)) |
There was a problem hiding this comment.
Stumbled upon this today. I was trying to connect a production Prax to the dev Dex explorer and it would silently fail. Think we should drop the requirement that the dev version of Prax is needed to connect to localhost sites:
parsedOrigin.protocol in ValidProtocol ||
- (globalThis.__DEV__ && isHttpLocalhost(parsedOrigin))
+ isHttpLocalhost(parsedOrigin)@VanishMax can you open a follow PR on this?
Closes #107
Relates to #129 and the reverting PR #145.
Allows http protocol for localhost