Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

inject request method without handling neutered port #181

Merged
merged 3 commits into from
Aug 28, 2024
Merged

inject request method without handling neutered port #181

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
07fd040
inject request method
turbocrime Aug 22, 2024
b30e260
comment
turbocrime Aug 23, 2024
25acfc6
prevent "Port at index 0 is already neutered"
turbocrime Aug 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions apps/extension/src/content-scripts/injected-penumbra-global.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,16 @@ class PraxInjection {
private stateEvents = new EventTarget();

private injection: Readonly<PenumbraProvider> = Object.freeze({
/**
* Meet the 'request' method of the old page API to mitigate incompatibility
* with pd v0.80.0's bundled minifront. This prevents connection failure.
* @todo Remove when bundled frontends are updated beyond `a31d54a`
* @issue https://github.com/prax-wallet/web/issues/175
*/
request: async () => {
await Promise.resolve(this.port ?? this.postConnectRequest());
},

connect: () => Promise.resolve(this.port ?? this.postConnectRequest()),
disconnect: () => this.postDisconnectRequest(),
isConnected: () => Boolean(this.port && this.presentState === PenumbraState.Connected),
Expand Down