Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use updated packages #192

Merged
merged 11 commits into from
Sep 8, 2024
Merged

use updated packages #192

merged 11 commits into from
Sep 8, 2024

Conversation

TalDerei
Copy link
Contributor

@TalDerei TalDerei commented Sep 5, 2024

follow-up from penumbra-zone/web#1768

@TalDerei
Copy link
Contributor Author

TalDerei commented Sep 6, 2024

cc @turbocrime

screenshot_2024-09-05_at_11 35 37___pm

@turbocrime
Copy link
Contributor

turbocrime commented Sep 6, 2024

you updated @bufbuild/protobuf accross a major version with breaking changes. syncpack is now configured to restrict its version.

unfortunately, some recent changes in the web repo are breaking vitest - the svgr tool was added which requires a URL reference to SVG files, and one was applied.

now wasm imports don't work perhaps related to this issue vitest-dev/vitest#2150

i'll try the workaround, and also PR a fix for the web repo.

edit: wait, that can't be right. the svgr plugin use and url ref aren't in an exported package...

@turbocrime turbocrime changed the title update optional getters use updated packages Sep 6, 2024
@turbocrime
Copy link
Contributor

turbocrime commented Sep 6, 2024

getters aren't the problem. example branches

fdc93fc based on b14f093 with packages built from penumbra-zone/web@3a5c074 getter refactor

  • uses the correct protobufs
  • consumes the optional getters refactor
  • tests pass

37fa0bb based on the tip of main with packages built from penumbra-zone/web@74527df, the last commit before package release

  • uses the correct protobufs
  • consumes the optional getters refactor
  • tests pass

@turbocrime
Copy link
Contributor

you also version bumped vitest, that was the source of the problem.

@turbocrime
Copy link
Contributor

also RM prax-marketing site #182

Comment on lines +24 to +33
{
"range": "",
"dependencies": [
"@penumbra-zone/**",
"@prax-wallet/**"
],
"packages": [
"**"
]
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this configuration means version specifiers must be exact.

@TalDerei
Copy link
Contributor Author

TalDerei commented Sep 8, 2024

instead of pnpm -r update --latest, the command pnpm update --latest --save-exact included breaking version ranges...

@TalDerei TalDerei merged commit 1246af2 into main Sep 8, 2024
3 checks passed
@TalDerei TalDerei deleted the update-getters branch September 8, 2024 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants