fix: beta extension bundle #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grod220
approved these changes
Oct 11, 2024
| import path from 'node:path'; | ||
| import config from './webpack.config.js'; | ||
|
|
||
| dotenv.config({ path: '.env', override: true }); |
There was a problem hiding this comment.
question: would it make it simpler if we didn't have an env file at all and just put the ids in the respective prod vs beta webpack configs?
There was a problem hiding this comment.
Yes, I like that! Removed the .env files in favor of string replacements
This was referenced Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to penumbra-zone/web#1811
The extension relies on the
.envfile that sets thePRAXvariable with the chrome extension ID. This ID is then used to correctly inject the provider to web pages. The build process didn't consider it, and the BETA extension injected the prod ID. Theclientpackage, in its turn, always checks the injected id matches chrome manifest to avoid security breaches, – it all means the BETA package didn't work completely.This PR fixes the issue with BETA extension not being built correctly:
prodandbetaversions.envfiles in favor of string replacementsbeta-distdirectorymanifest.jsonfile to update favicons and info about the extension