don't retain port in content scripts #285
Conversation
| import { createPenumbraStateEvent } from '@penumbra-zone/client/event'; | ||
| import type { PenumbraProvider } from '@penumbra-zone/client/provider'; |
There was a problem hiding this comment.
not strictly necessary, but due to poor webpack tree-shaking, importing from the root package apparently caused the generated script to be very large.
a more specific import significantly reduces the size of the content script.
| disconnect: () => this.postDisconnectRequest(), | ||
| isConnected: () => Boolean(this.port && this.presentState === PenumbraState.Connected), | ||
| isConnected: () => this.presentState === PenumbraState.Connected, |
There was a problem hiding this comment.
i would like to do some more investigation to identify possibly unknown problems with these changes to state transitions
| private postDisconnectRequest() { | ||
| const attempt = this.listenEndMessage(); | ||
| window.postMessage(disconnectMessage, '/', []); | ||
| return attempt; | ||
| } |
There was a problem hiding this comment.
pulled this out into its own method to match the structure of the connect request logic
| if (this.presentState !== PenumbraState.Connected) { | ||
| this.setPending(); | ||
| } |
There was a problem hiding this comment.
this change needs some closer inspection too
| window.addEventListener('message', praxDocumentListener); | ||
| chrome.runtime.onMessage.addListener(praxExtensionListener); |
There was a problem hiding this comment.
can we add code comments to the two event listeners, praxDocumentListener and praxExtensionListener?
turbocrime
force-pushed
the
dont-violate-transfer
branch
from
fd2699a to
db1ef53
Compare
turbocrime
force-pushed
the
dont-violate-transfer
branch
from
db1ef53 to
c9ed017
Compare
Content scripts no longer retain a
MessagePortin violation of object transfer rules.The
injected-penumbra-global.tscontent script has no insight to channel state, and as a mainworld script should not be relied upon to manage channel state. So this takes the approach of always requesting a new port.The
injected-listeners.tscontent script cannot re-provide a port, since it must retain no reference. So this depends on changes in penumbra-zone/web#2018 so it may launch a new session for each request.