Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use penumbra-zone packages instead local alternatives #29

Closed
wants to merge 6 commits into from

Conversation

VanishMax
Copy link
Contributor

@VanishMax VanishMax commented Jun 13, 2024

Closes #9

Closes #10

Closes #11

Closes #11

Uses tsup library to build and minify TS files. Plus, correct exports

Needs penumbra-zone/web#1292 to proceed

Copy link

changeset-bot bot commented Jun 13, 2024

⚠️ No Changeset found

Latest commit: 2e78389

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@VanishMax VanishMax changed the title feat: use penumbra-zone bech32m package instead local alternative draft: feat: use penumbra-zone bech32m package instead local alternative Jun 13, 2024
@VanishMax VanishMax marked this pull request as draft June 13, 2024 13:11
@VanishMax VanishMax changed the title draft: feat: use penumbra-zone bech32m package instead local alternative feat: use penumbra-zone packages instead local alternatives Jun 14, 2024
# Conflicts:
#	packages/bech32m/package.json
#	packages/client/package.json
#	packages/getters/package.json
#	packages/protobuf/package.json
#	pnpm-lock.yaml
@VanishMax VanishMax self-assigned this Jun 14, 2024
@grod220
Copy link
Contributor

grod220 commented Jun 14, 2024

(✅ assuming after the external ones are swapped in)

@VanishMax VanishMax marked this pull request as ready for review June 14, 2024 15:39
Copy link
Contributor

@turbocrime turbocrime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blocking in favor of #34 which can go as soon as publish happens

@turbocrime turbocrime closed this Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

client [use npm version] getters [use npm version] bech32m [use npm version]
3 participants