fulfill disconnect interface #56
Conversation
🦋 Changeset detectedLatest commit: 4da58ad The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
turbocrime
force-pushed
the
turbocrime/use-disconnect
branch
2 times, most recently
from
8b2f790
to
4f25eb4
Compare
There was a problem hiding this comment.
some mild reorganization
apps/extension/src/storage/origin.ts
Outdated
There was a problem hiding this comment.
storage utilities moved to storage dir
| @@ -22,6 +22,7 @@ export interface LocalStorageState { | |||
| frontendUrl: string | undefined; | |||
| passwordKeyPrint: KeyPrintJson | undefined; | |||
| fullSyncHeight: number | undefined; | |||
| // TODO: It's likely that an array is not the best data structure for this in storage. Should revisit later. | |||
There was a problem hiding this comment.
moved this comment to the storage types definition
There was a problem hiding this comment.
disconnect implementation
turbocrime
force-pushed
the
turbocrime/use-disconnect
branch
2 times, most recently
from
80a738e
to
4e1a17d
Compare
| @@ -41,7 +40,7 @@ | |||
| }, | |||
| "web_accessible_resources": [ | |||
| { | |||
| "resources": ["manifest.json"], | |||
| "resources": ["manifest.json", "favicon/*"], | |||
There was a problem hiding this comment.
expose the extension icon so dapps may use it
There was a problem hiding this comment.
injection is refactored into a class to more clearly and explicitly manage state.
the interface is async. so to provide the synchronous isConnected state querying method, the state of the three possible actions are tracked, and resolved in the private function state.
as expected, isConnected() => true would indicate an active connection.
more information on the interface is available in client package documentation, but what it comes down to is:
- if no action has been attempted, the connection state is undefined.
- if the page has called
requestbut the request is still pending, the connection state is undefined. - if the page has called
requestbut the request failed, the connection state is false. - if connection has succeeded, the connection state is true.
- if the page has called
disconnect, the connection state is false.
|
Going to take this PR over, rebase, and merge so we can cut a release given the proving key update |
grod220
force-pushed
the
turbocrime/use-disconnect
branch
from
792a1aa
to
4da58ad
Compare
|
thanks |
fulfill the disconnect interface published in
@penumbra-zone/client@9