Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: #51: sync UI package #57

Merged
merged 6 commits into from
Jun 25, 2024
Merged

feat: #51: sync UI package #57

merged 6 commits into from
Jun 25, 2024

Conversation

VanishMax
Copy link
Contributor

Closes #51

  • Syncs UI package with penumbra-zone/ui via cherry pick
  • Removes unused components and their dependencies

VanishMax and others added 3 commits June 25, 2024 12:47
* ui package imports

* fix(ui): move penumbra packages to dev dependencies

* fix(ui): don't export components directory from UI

* feat(ui): #1336: start separating ui components

* feat(ui): #1336: Put all components in directories

* fix(ui): linting and tests

* chore: add changesets

* fix: put the repo/ui package name back

* fix: after the merge

---------

Co-Authored-By: Tal Derei <[email protected]>
@VanishMax VanishMax requested review from TalDerei and a team June 25, 2024 11:09
@VanishMax VanishMax self-assigned this Jun 25, 2024
Copy link
Contributor

@TalDerei TalDerei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking this on!

@@ -9,7 +9,7 @@ import {
getClaimFeeFromSwapView,
getClaimTx,
} from '@penumbra-zone/getters/swap-view';
import { ValueViewComponent } from '../value';
import { ValueViewComponent } from '../../../value';
import { ActionDetails } from '../action-details';
import { joinLoHiAmount } from '@penumbra-zone/types/amount';
import { getAmount } from '@penumbra-zone/getters/fee';
Copy link
Contributor

@TalDerei TalDerei Jun 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TalDerei thanks, fixed it. Is everything else in place?

@@ -1,4 +1,4 @@
import { ValueViewComponent } from '../value';
import { ValueViewComponent } from '../../../value';
import { ArrowRight } from 'lucide-react';
import { ValueView } from '@buf/penumbra-zone_penumbra.bufbuild_es/penumbra/core/asset/v1/asset_pb';
import { getAmount, getSymbolFromValueView } from '@penumbra-zone/getters/value-view';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on line 21, instead of {outputAmount ? <ValueViewComponent view={output} /> : getSymbolFromValueView(output)} should be <ValueViewComponent view={output} showValue={!!outputAmount} />

@TalDerei
Copy link
Contributor

TalDerei commented Jun 25, 2024

@VanishMax compare the structural package organization in https://github.com/penumbra-zone/web/tree/main/packages/ui/components/ui compared to https://github.com/prax-wallet/web/tree/main/packages/ui/components/ui.

edit: disregard comment

@VanishMax VanishMax merged commit c04a858 into main Jun 25, 2024
3 checks passed
@VanishMax VanishMax deleted the feat/#51-sync-ui-package branch June 25, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sync ui package with web
3 participants