feat: #51: sync UI package #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* ui package imports * fix(ui): move penumbra packages to dev dependencies * fix(ui): don't export components directory from UI * feat(ui): #1336: start separating ui components * feat(ui): #1336: Put all components in directories * fix(ui): linting and tests * chore: add changesets * fix: put the repo/ui package name back * fix: after the merge --------- Co-Authored-By: Tal Derei <[email protected]>
grod220
approved these changes
Jun 25, 2024
TalDerei
approved these changes
Jun 25, 2024
TalDerei
reviewed
Jun 25, 2024
| @@ -9,7 +9,7 @@ import { | |||
| getClaimFeeFromSwapView, | |||
| getClaimTx, | |||
| } from '@penumbra-zone/getters/swap-view'; | |||
| import { ValueViewComponent } from '../value'; | |||
| import { ValueViewComponent } from '../../../value'; | |||
| import { ActionDetails } from '../action-details'; | |||
| import { joinLoHiAmount } from '@penumbra-zone/types/amount'; | |||
| import { getAmount } from '@penumbra-zone/getters/fee'; | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
@TalDerei thanks, fixed it. Is everything else in place?
TalDerei
reviewed
Jun 25, 2024
| @@ -1,4 +1,4 @@ | |||
| import { ValueViewComponent } from '../value'; | |||
| import { ValueViewComponent } from '../../../value'; | |||
| import { ArrowRight } from 'lucide-react'; | |||
| import { ValueView } from '@buf/penumbra-zone_penumbra.bufbuild_es/penumbra/core/asset/v1/asset_pb'; | |||
| import { getAmount, getSymbolFromValueView } from '@penumbra-zone/getters/value-view'; | |||
There was a problem hiding this comment.
on line 21, instead of {outputAmount ? <ValueViewComponent view={output} /> : getSymbolFromValueView(output)} should be <ValueViewComponent view={output} showValue={!!outputAmount} />
|
@VanishMax compare the structural package organization in https://github.com/penumbra-zone/web/tree/main/packages/ui/components/ui compared to https://github.com/prax-wallet/web/tree/main/packages/ui/components/ui. edit: disregard comment |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #51