fix: trim trailing slash from custom rpc url

[vacekj]

Fixes edge case where entering a custom RPC URL with a trailing slash will result in links in other parts of the app being broken.

@grod220 I couldn't find a corresponding test file for this form - should I create one?

[changeset-bot]

⚠️ No Changeset found

Latest commit: 4f437a7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[turbocrime]

thanks!

i think instead of manipulating the input with a regex, which is unreliable and may be confusing to a user attempting to type in the input, we should use the browser's validation tools before testing and saving the url.

on my phone at the moment, but something like new URL(grpcEndpointInput).href at the appropriate locations should generate a canonical format, and provide comprehensive validation and formatting.

additionally, we should look for code that concatenates URLs as strings, instead of using these tools which also provide correct path joining. this would be the true source of the double slash.

[vacekj]

Agree.

the input is already marked as type="url", so that provides enough validation imo. In terms of joining the URL, we can indeed use the URL constructor:

new URL('/one', 'http://example.com/').href

which works with or without a trailing slash.

[vacekj]

@turbocrime requesting re-review, lmk if there's anything else I should change. @prax-wallet/web-reviewers also, thanks!

[turbocrime]

looks good to me