extension reloading webpack plugin #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
turbocrime
commented
Jul 3, 2024
turbocrime
commented
Jul 3, 2024
apps/extension/webpack.config.ts
Outdated
Comment on lines
48
to
68
| const WebExtReloadPlugin = { | ||
| webExtRun: undefined as IExtensionRunner | undefined, | ||
| apply({ hooks }: webpack.Compiler) { | ||
| hooks.afterEmit.tapPromise( | ||
| { name: 'WebExt Reloader' }, | ||
| async ({ options }: webpack.Compilation) => { | ||
| await this.webExtRun?.reloadAllExtensions(); | ||
| this.webExtRun ??= await WebExtCmd.run({ | ||
| target: 'chromium', | ||
| keepProfileChanges: Boolean(CHROMIUM_PROFILE), | ||
| chromiumProfile: CHROMIUM_PROFILE, | ||
| profileCreateIfMissing: Boolean(CHROMIUM_PROFILE), | ||
| sourceDir: options.output.path, | ||
| startUrl: 'https://localhost:5173/', | ||
| }); | ||
| this.webExtRun.registerCleanup(() => (this.webExtRun = undefined)); | ||
| }, | ||
| ); | ||
| }, | ||
| }; | ||
|
|
There was a problem hiding this comment.
this is much like the small webpack plugin in the initial transport-demo
turbocrime
commented
Jul 3, 2024
| async ({ options }: webpack.Compilation) => { | ||
| await this.webExtRun?.reloadAllExtensions(); | ||
| this.webExtRun ??= await WebExtCmd.run({ | ||
| target: 'chromium', |
There was a problem hiding this comment.
target is labelled 'chromium' but it will execute actual Chrome by default
TalDerei
approved these changes
Jul 9, 2024
turbocrime
force-pushed
the
turbocrime/web-ext-plugin
branch
from
c26fd34
to
6c63dfe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this adds a webpack plugin that
content scripts can't re-inject, so you'll still have to reload pages.
you can activate the plugin by specifying a chromium profile directory, either outside the repository or at the conveniently gitignored 'chromium-profile'
CHROMIUM_PROFILE='chromium-profile' pnpm dev