[types] permit undefined createContext initial value #3407

developit · 2022-01-11T18:02:20Z

No description provided.

coveralls · 2022-01-11T18:04:43Z

Coverage remained the same at 99.625% when pulling b6053a1 on types-createcontext-default-value into d4a3013 on master.

developit · 2022-01-11T18:08:28Z

src/index.d.ts

@@ -307,4 +307,4 @@ export interface Context<T> {
 }
 export interface PreactContext<T> extends Context<T> {}

-export function createContext<T>(defaultValue: T): Context<T>;
+export function createContext<T = undefined>(defaultValue: T): Context<T>;


Or maybe this?

Suggested change

export function createContext<T = undefined>(defaultValue: T): Context<T>;

export function createContext<T>(defaultValue: T): Context<T>;

export function createContext<T extends undefined>(defaultValue?: T): Context<T>;

[types] permit undefined createContext initial value

6584828

developit commented Jan 11, 2022

View reviewed changes

Merge branch 'master' into types-createcontext-default-value

b6053a1

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[types] permit undefined createContext initial value #3407

[types] permit undefined createContext initial value #3407

developit commented Jan 11, 2022

coveralls commented Jan 11, 2022 •

edited

Loading

developit Jan 11, 2022

	export function createContext<T = undefined>(defaultValue: T): Context<T>;
	export function createContext<T>(defaultValue: T): Context<T>;
	export function createContext<T extends undefined>(defaultValue?: T): Context<T>;

[types] permit undefined createContext initial value #3407

Are you sure you want to change the base?

[types] permit undefined createContext initial value #3407

Conversation

developit commented Jan 11, 2022

coveralls commented Jan 11, 2022 • edited Loading

developit Jan 11, 2022

Choose a reason for hiding this comment

coveralls commented Jan 11, 2022 •

edited

Loading