Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ownerdocument rebased #4501

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

alshdavid
Copy link

No description provided.

@JoviDeCroock
Copy link
Member

Looks like the tests are currently failing when passing in document as a render-target. This is a valid use-case to render a full HTML tree and that indeed has null for the ownerDocument so we'd have to take a null'ish ownerDocument into account and default to document I reckon.

@hzy
Copy link

hzy commented Sep 27, 2024

It looks like some of the tests regarding types are not passing, would the following changes help?

diff --git a/test/ts/preact.tsx b/test/ts/preact.tsx
index 3713f9d8..e6d81eb3 100644
--- a/test/ts/preact.tsx
+++ b/test/ts/preact.tsx
@@ -102,7 +102,8 @@ function createRootFragment(parent: Element, replaceNode: Element | Element[]) {
                appendChild: (c: Node) => insert(c, null),
                removeChild: function (c: Node) {
                        return parent.removeChild(c);
-               }
+               },
+               ownerDocument: parent.ownerDocument,
        });
 }

@JoviDeCroock
Copy link
Member

CC @marvinhagemeister how should we best handle the undefined case you think, might be relevant for fresh?

@alshdavid alshdavid force-pushed the ownerdocument-rebased branch 3 times, most recently from 5f33510 to c8e207e Compare February 19, 2025 02:43
Copy link

github-actions bot commented Feb 19, 2025

📊 Tachometer Benchmark Results

Summary

A summary of the benchmark results will show here once they finish.

Results

The full results of your benchmarks will show here once they finish.

tachometer-reporter-action v2 for CI

@alshdavid
Copy link
Author

I have squashed the changes and added @Hydrophobefireman as a co-author. Should make it easier to rebase in future. There are some issues (even with main). I am unable to run npm run test:mocha locally, not sure what additional configuration I need to do to get that working

@alshdavid alshdavid force-pushed the ownerdocument-rebased branch from c8e207e to 91689ec Compare February 19, 2025 02:46
@rschristian
Copy link
Member

I am unable to run npm run test:mocha locally

You probably need to add "type": "commonjs" to the pkg.json, I'm guessing you're on Node v22+. We tried to add that but it broke some of people's setups. Seems that Node has changed how require hooks work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants