-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ownerdocument rebased #4501
base: main
Are you sure you want to change the base?
Ownerdocument rebased #4501
Conversation
Looks like the tests are currently failing when passing in |
It looks like some of the tests regarding types are not passing, would the following changes help? diff --git a/test/ts/preact.tsx b/test/ts/preact.tsx
index 3713f9d8..e6d81eb3 100644
--- a/test/ts/preact.tsx
+++ b/test/ts/preact.tsx
@@ -102,7 +102,8 @@ function createRootFragment(parent: Element, replaceNode: Element | Element[]) {
appendChild: (c: Node) => insert(c, null),
removeChild: function (c: Node) {
return parent.removeChild(c);
- }
+ },
+ ownerDocument: parent.ownerDocument,
});
} |
CC @marvinhagemeister how should we best handle the undefined case you think, might be relevant for fresh? |
5f33510
to
c8e207e
Compare
📊 Tachometer Benchmark ResultsSummaryA summary of the benchmark results will show here once they finish. ResultsThe full results of your benchmarks will show here once they finish. |
I have squashed the changes and added @Hydrophobefireman as a co-author. Should make it easier to rebase in future. There are some issues (even with |
Co-authored-by: Hydrophobefireman <[email protected]>
c8e207e
to
91689ec
Compare
You probably need to add |
No description provided.