Attekmi: Remove partnerName param requirement

[SmartHubSolutions]

• This hotfix is ​​required for the following PRs:
  Attekmi: add Addigi adapter prebid.github.io#5836
  Attekmi: add new adapter Adinify prebid.github.io#5822

[github-actions]

Code coverage summary

Note:

• Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
• Coverage summary encompasses all commits leading up to the latest one, f981147

smarthub

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/smarthub/smarthub.go:30:	Builder			80.0%
github.com/prebid/prebid-server/v3/adapters/smarthub/smarthub.go:43:	getImpressionExt	100.0%
github.com/prebid/prebid-server/v3/adapters/smarthub/smarthub.go:61:	buildEndpointURL	100.0%
github.com/prebid/prebid-server/v3/adapters/smarthub/smarthub.go:74:	MakeRequests		86.7%
github.com/prebid/prebid-server/v3/adapters/smarthub/smarthub.go:111:	MakeBids		96.4%
github.com/prebid/prebid-server/v3/adapters/smarthub/smarthub.go:187:	getBidType		100.0%
total:									(statements)		93.3%

[SmartHubSolutions]

@SyntaxNode @bsardo Please review it.

[bsardo]

Since none of your params are now considered required, please add the following test cases to validParams to ensure that the absence of each param is valid, the empty string is allowed for partnerId and a minimum length of 1 is valid for seat and token:

{"partnerName":""}
{"partnerName":"1"}
{"seat":"1"},
{"token":"1"},

[SmartHubSolutions]

ok I added this test cases and all tests was passed

[SyntaxNode]

Since none of your params are now considered required

@bsardo - The seat and token params are still required in this schema.

[SmartHubSolutions]

Hmm this cases I added to invalidParams because we using parnterName+seat+token OR seat+token in aliases, this means that the pair seat+token will always be required.

For example:

prebid-server/static/bidder-info/smarthub.yaml

Line 1 in 2b23016

endpoint: "https://prebid.attekmi.com/pbserver?partnerName={{.Host}}&seat={{.AccountID}}&token={{.SourceId}}"

prebid-server/static/bidder-info/vimayx.yaml

Line 1 in 2b23016

endpoint: "https://vimayx-prebid.attekmi.com/pbserver/?seat={{.AccountID}}&token={{.SourceId}}"

[github-actions]

Code coverage summary

Note:

• Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
• Coverage summary encompasses all commits leading up to the latest one, f4bedfc

smarthub

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/smarthub/smarthub.go:30:	Builder			80.0%
github.com/prebid/prebid-server/v3/adapters/smarthub/smarthub.go:43:	getImpressionExt	100.0%
github.com/prebid/prebid-server/v3/adapters/smarthub/smarthub.go:61:	buildEndpointURL	100.0%
github.com/prebid/prebid-server/v3/adapters/smarthub/smarthub.go:71:	MakeRequests		86.7%
github.com/prebid/prebid-server/v3/adapters/smarthub/smarthub.go:108:	MakeBids		96.4%
github.com/prebid/prebid-server/v3/adapters/smarthub/smarthub.go:184:	getBidType		100.0%
total:									(statements)		93.1%

[SyntaxNode]

Might be better to delete the Host template param entirely. This is only used for endpoint macros and neither smarthub nor its aliases use this macro.

[SmartHubSolutions]

Currently, we use both methods of redirecting traffic, both through partnerName and using aliases.We also need to use param partnerName to temporarily connect partners.

[SyntaxNode]

Ah, I see. The aliases do not use this macro, but the base smarthub adapter does. Ok.