Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attekmi: add Addigi adapter #5836

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
+39 −0
Open

Attekmi: add Addigi adapter #5836

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ecc9d93
Attekmi: add Addigi adapter
Jan 28, 2025
80e2bc8
multiformat_supported and pbs params change
Feb 11, 2025
4ca1787
pbs to true
Feb 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 39 additions & 0 deletions dev-docs/bidders/addigi.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
---
layout: bidder
title: Addigi
description: Addigi Bidder Adapter
biddercode: addigi
aliasCode : smarthub
usp_supported: true
coppa_supported: true
schain_supported: true
dchain_supported: true
media_types: banner, video, native
safeframes_ok: true
deals_supported: true
floors_supported: true
fpd_supported: false
pbjs: true
pbs: false
SmartHubSolutions marked this conversation as resolved.
Show resolved Hide resolved
pbs_app_supported: true
multiformat_supported: will-bid-on-any
---

### Prebid.js Bid Params

{: .table .table-bordered .table-striped }
| Name | Scope | Description | Example | Type |
|---------------|----------|---------------------------------|-------------------------------------|-----------|
| `seat` | required | Seat value | `'9Q20EdGxzgWdfPYShScl'` | `string` |
| `token` | required | Token | `'eKmw6alpP3zWQhRCe3flOpz0wpuwRFjW'` | `string` |
| `iabCat` | optional | Array of IAB content categories that describe the content producer | `['IAB1-1', 'IAB3-1', 'IAB4-3']` | `Array(String)` |
| `minBidfloor` | optional | Minimal CPM value | `0.03` | `float` |
| `pos` | optional | The position of the placement on the page, see Open RTB spec v2.5. | `4` | `number` |

### Prebid Server Bid Params

{: .table .table-bordered .table-striped }
| Name | Scope | Description | Example | Type |
|---------------|----------|---------------------|--------------------------------------|----------|
| `seat` | required | Seat value | `'9Q20EdGxzgWdfPYShScl'` | `string` |
| `token` | required | Token | `'eKmw6alpP3zWQhRCe3flOpz0wpuwRFjW'` | `string` |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The adapter being aliased also requires partnerName. Please include that as a required field for Prebid Server Bid Params section.

Copy link
Contributor Author

@SmartHubSolutions SmartHubSolutions Feb 12, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no need to use this parameter. We have foreseen this case.
When the partner will use this adapter, the value of partnerName will be substituted from the code, this should work on Prebid.js and Prebid-server sides

prebid.js will be work correct if partnerName will be not passed

not required on prebid-server

url of alias not uses partnerName

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not required on prebid-server

The code you linked to does not affect the processing of required / not required fields. That is controlled by the bidder params json schema, here for Attekmi and the Addigi alias.:

https://github.com/prebid/prebid-server/blob/1b34580a44b367cd2b00a71c8db6bb69713e2a81/static/bidder-params/smarthub.json#L24

Looking at the base adapter code, it seems the partnerName was only used for a host macro. The host macro was removed (thank you), but the requirement remains.

the value of partnerName will be substituted from the code

No such code exists in the adapter.

If this is the desired behavior, could you please update for adapter code?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm trying make fix in this PR prebid/prebid-server#4208