Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #45

Merged
merged 10 commits into from
Jan 6, 2021
Merged

Update dependencies #45

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
4191f6f
update minimist
aminya Oct 20, 2020
a81f2ba
update mkdirp
aminya Oct 20, 2020
4e16973
update node-abi
aminya Oct 20, 2020
a047e19
update npm-run-path
aminya Oct 20, 2020
afb936f
update nan
aminya Oct 20, 2020
20d030b
Revert "update mkdirp"
aminya Oct 20, 2020
75564f1
downgrade to mkdirp-classic
aminya Oct 20, 2020
247acf5
fix sorting of devDependencies
aminya Oct 20, 2020
89708ea
downgrade npm-run-path
aminya Oct 20, 2020
9a8a426
do not install future 3.* patches for npm-run-path
aminya Oct 25, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,15 +63,14 @@ function prebuildify (opts, cb) {
// over the local .bin folder. Counter that by (again) adding .bin to PATH.
opts.env = npmRunPath.env({ env: opts.env, cwd: opts.cwd })

mkdirp(opts.builds, function (err) {
if (err) return cb(err)
mkdirp(opts.builds).then(function () {
loop(opts, function (err) {
if (err) return cb(err)

if (opts.artifacts) return copyRecursive(opts.artifacts, opts.builds, cb)
return cb()
})
})
}).catch(function (err) { return cb(err) })
vweevers marked this conversation as resolved.
Show resolved Hide resolved
}

function loop (opts, cb) {
Expand Down Expand Up @@ -197,7 +196,7 @@ function build (target, runtime, opts, cb) {
args.push('--release')
}

mkdirp(cache, function () {
mkdirp(cache).then(function () {
var child = proc.spawn(opts.nodeGyp, args, {
cwd: opts.cwd,
env: opts.env,
Expand All @@ -216,7 +215,7 @@ function build (target, runtime, opts, cb) {
})
})
})
})
}).catch(function (err) { return console.warn(err) })
}

function findBuild (dir, cb) {
Expand Down
12 changes: 6 additions & 6 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,17 +5,17 @@
"main": "index.js",
"dependencies": {
"execspawn": "^1.0.1",
"minimist": "^1.2.0",
"mkdirp": "^0.5.1",
"node-abi": "^2.0.0",
"npm-run-path": "^3.1.0",
"mkdirp": "^1.0.4",
"node-abi": "^2.19.1",
"npm-run-path": "^4.0.1",
aminya marked this conversation as resolved.
Show resolved Hide resolved
"minimist": "^1.2.5",
"pump": "^3.0.0",
"tar-fs": "^2.1.0"
},
"devDependencies": {
"nan": "^2.5.1",
"standard": "^13.0.1",
"tape": "^4.6.3"
"tape": "^4.6.3",
"nan": "^2.14.2"
aminya marked this conversation as resolved.
Show resolved Hide resolved
},
"bin": {
"prebuildify": "./bin.js"
Expand Down