Skip to content

Commit

Permalink
Docker test
Browse files Browse the repository at this point in the history
  • Loading branch information
tgaddair committed Nov 1, 2024
1 parent 20cf752 commit 2868acc
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 11 deletions.
6 changes: 2 additions & 4 deletions .github/workflows/build.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ on:
push:
branches:
- 'main'
- 'optimizations'
tags:
- 'v*'

Expand Down Expand Up @@ -69,10 +70,7 @@ jobs:
images: |
ghcr.io/predibase/lorax
tags: |
type=semver,pattern={{version}}
type=semver,pattern={{major}}.{{minor}}
type=sha,prefix=,suffix=,format=short
type=raw,value=main,enable=${{ github.ref == 'refs/heads/main' }}
type=raw,value=optimizations-5,enable=${{ github.ref == 'refs/heads/optimizations' }}
- name: Create a hash from tags
env:
Expand Down
1 change: 0 additions & 1 deletion router/src/batch.rs
Original file line number Diff line number Diff line change
Expand Up @@ -222,7 +222,6 @@ impl BatchEntriesState {
// TODO(travis): clone is not ideal, find a way to do this cleanly in place
for r in self.batch_requests.clone().into_iter().rev() {
let id = r.id;
tracing::info!("!!! drain::remove entry id={id:?}");
let entry = self.batch_entries.remove(&id).unwrap();
let adapter_index = r.adapter_index;
let adapter = self.index_to_adapter.get_mut(&adapter_index).unwrap();
Expand Down
6 changes: 0 additions & 6 deletions router/src/infer.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1323,7 +1323,6 @@ fn filter_send_generations(generations: Vec<Generation>, entries: &mut IntMap<u6
let id = generation.request_id;
// Get entry
// We can `expect` here as the request id should always be in the entries
tracing::info!("!!! filter_send_generations id={id:?}");
let entry = entries
.get(&id)
.expect("ID not found in entries. This is a bug.");
Expand All @@ -1338,7 +1337,6 @@ fn filter_send_generations(generations: Vec<Generation>, entries: &mut IntMap<u6
metrics::increment_counter!("lorax_request_failure", "err" => "dropped");
}).unwrap_or(true);
if stopped {
tracing::info!("!!! filter_send_generations::remove entry id={id:?}");
entries.remove(&id).expect("ID not found in entries. This is a bug.");
}
});
Expand All @@ -1351,7 +1349,6 @@ fn send_responses(
) -> Result<bool, Box<SendError<Result<InferStreamResponse, InferError>>>> {
// Return directly if the channel is disconnected
if entry.response_tx.is_closed() {
tracing::info!("!!! send_responses::disconnected");
return Ok(true);
}

Expand Down Expand Up @@ -1410,9 +1407,6 @@ fn send_responses(

match (&generation.generated_text, iterator.peek()) {
(Some(generated_text), None) => {
tracing::info!(
"!!! send_responses::generation_ended id={id:?} generated_text={generated_text:?}"
);
// Generation has ended
stopped = true;
// Send message
Expand Down

0 comments on commit 2868acc

Please sign in to comment.