Don't build docker

predibase · Jul 16, 2024 · caf9a1c · caf9a1c
1 parent 0377c3d
commit caf9a1c
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml
@@ -5,7 +5,6 @@ on:
   push:
     branches:
       - 'main'
-      - 'predownload-adapters'
     tags:
       - 'v*'
 
@@ -63,7 +62,10 @@ jobs:
           images: |
             ghcr.io/predibase/lorax
           tags: |
-            type=raw,value=predownload-adapters,enable=${{ github.ref == 'refs/heads/predownload-adapters' }}
+            type=semver,pattern={{version}}
+            type=semver,pattern={{major}}.{{minor}}
+            type=sha,prefix=,suffix=,format=short
+            type=raw,value=main,enable=${{ github.ref == 'refs/heads/main' }}
 
       - name: Create a hash from tags
         env:

diff --git a/server/lorax_server/server.py b/server/lorax_server/server.py
@@ -280,6 +280,8 @@ async def serve_inner(
 
         if preloaded_adapter_ids:
             logger.info(f"Preloading {len(preloaded_adapter_ids)} adapters")
+
+            # Download adapters
             requests = [
                 generate_pb2.DownloadAdapterRequest(
                     adapter_parameters=generate_pb2.AdapterParameters(adapter_ids=[adapter_id]),
@@ -295,7 +297,7 @@ async def serve_inner(
             if not all(responses):
                 raise RuntimeError("Failed to preload all adapters")
 
-            # TODO(travis): load weights into GPU memory as well
+            # Load adapters
             for i, adapter_id in enumerate(preloaded_adapter_ids):
                 if adapter_source == PBASE:
                     adapter_id = map_pbase_model_id_to_s3(adapter_id, api_token=None)