-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for H100s #111
Conversation
5892053
to
58b3c0c
Compare
https://github.com/enricai/lorax/blob/58b3c0c7a97f3e43355af4965afc09668e58f571/Dockerfile#L40 Could you set the pytorch version in docker to 2.1.1 too ? |
@flozi00 Done!! |
Build issue should be fixed now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I'll go ahead and land, and then do some robustness tests after the new image goes out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@thelinuxkid looks like based on the tests we actually need to add back peft
as a dependency.
@thelinuxkid alternatively, would you mind giving me edit access to the branch / PR so I can make these changes while I test things out? |
@tgaddair just added, will wait for tests to see if they turn out OK this time |
Hey @thelinuxkid, apologies, but can you add these to
|
@tgaddair Done! Also gave you access as maintainer to our fork |
f59856a
to
d1cae3e
Compare
2496dc7
to
77e87e2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ran a few tests earlier today with these changes. Everything looks good on my end. Merging!
Thanks @tgaddair ! When will this be available in the docker image? I'm not able to run with flash attn successfully. I build it but I still get an error that it doesn't exist when running it |
What does this PR do?
add support for H100s
Before submitting
to it if that's the case.
Who can review?
@arnavgarg1
@tgaddair
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
POC