Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enh: Expose ignore_eos_token option in generate requests #340

Merged
merged 4 commits into from
Mar 19, 2024
Merged

enh: Expose ignore_eos_token option in generate requests #340

merged 4 commits into from
Mar 19, 2024

Conversation

jeffreyftang
Copy link
Contributor

@jeffreyftang jeffreyftang commented Mar 19, 2024 •
edited
Loading

Closes #337

Screen Shot 2024-03-19 at 4 03 55 PM

@jeffreyftang jeffreyftang requested a review from tgaddair March 19, 2024 18:20
tgaddair
tgaddair reviewed Mar 19, 2024
View reviewed changes
Copy link
Contributor

@tgaddair tgaddair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add this to the python client as well?

tgaddair
tgaddair approved these changes Mar 19, 2024
View reviewed changes
Copy link
Contributor

@tgaddair tgaddair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tgaddair tgaddair merged commit 67579cc into main Mar 19, 2024
2 checks passed
@tgaddair tgaddair deleted the ignore-eos-token branch March 19, 2024 21:09
This was referenced Mar 19, 2024
Merged
Merged
@martinbomio martinbomio mentioned this pull request Mar 20, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgaddair tgaddair tgaddair approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expose ignore_eos_token on /generate and/or /v1/completions endpoints
2 participants
@jeffreyftang @tgaddair