-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Embedder Service v0 with FlashBert #385
Conversation
curl 127.0.0.1:8080/embed ;) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Couple minor questions.
|
||
class EmbedResponse(BaseModel): | ||
# Embeddings | ||
embeddings: Optional[List[float]] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this optional for embedding responses, or required?
@@ -86,6 +86,10 @@ def info(self) -> InfoResponse: | |||
@property | |||
def sliding_window_blocks(self) -> Optional[int]: | |||
return None | |||
|
|||
@property | |||
def supports_embeddings(self) -> bool: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Conversely, what happens when someone tries to use the BERT model for text generation?
Initialize:
Embed:
Python: