Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

int: Upgrade lorax-client to pydantic v2 #406

Closed
wants to merge 2 commits into from
Closed

int: Upgrade lorax-client to pydantic v2 #406

wants to merge 2 commits into from

Conversation

jeffreyftang
Copy link
Contributor

@jeffreyftang jeffreyftang commented Apr 10, 2024 •
edited
Loading

This PR bumps the required pydantic version, but imports from pydantic.v1, so functionality should remain the same.

@jeffreyftang jeffreyftang changed the title int: Upgrade to pydantic v2 int: Upgrade lorax-client to pydantic v2 Apr 10, 2024
@jeffreyftang jeffreyftang requested a review from tgaddair April 10, 2024 16:11
@jeffreyftang jeffreyftang marked this pull request as ready for review April 10, 2024 16:11
@jeffreyftang
Copy link
Contributor Author

Closing in favor of #405

@tgaddair tgaddair deleted the update-pydantic branch April 10, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgaddair tgaddair Awaiting requested review from tgaddair

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jeffreyftang