Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chunked prefill #653

Merged
merged 34 commits into from
Oct 21, 2024
Merged

Chunked prefill #653

merged 34 commits into from
Oct 21, 2024

Conversation

tgaddair
Copy link
Contributor

@tgaddair tgaddair commented Oct 17, 2024 •
edited
Loading

@tgaddair tgaddair marked this pull request as ready for review October 18, 2024 23:22
magdyksaleh
magdyksaleh approved these changes Oct 21, 2024
View reviewed changes
Copy link
Collaborator

@magdyksaleh magdyksaleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I want to add a test to make sure this doesn't break embedding and classification models but I can follow up with a pr

@ajtejankar
Copy link
Contributor

Looks good to me as well. I'll test it out once it's merged in.

@tgaddair
Copy link
Contributor Author

Good callout @magdyksaleh! I did test embeddings (though not NER) and got it working :)

@tgaddair tgaddair merged commit 6c5ca67 into main Oct 21, 2024
2 checks passed
@tgaddair tgaddair deleted the chunked-prefill branch October 21, 2024 19:04
@veezbo veezbo mentioned this pull request Oct 24, 2024
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magdyksaleh magdyksaleh magdyksaleh approved these changes

@ajtejankar ajtejankar Awaiting requested review from ajtejankar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tgaddair @ajtejankar @magdyksaleh