Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Embeddings with XLM-RoBERTa and Adapters #656

Merged
merged 2 commits into from
Oct 31, 2024

Conversation

jfhetzer
Copy link
Contributor

@jfhetzer jfhetzer commented Oct 23, 2024

What does this PR do?

This PR adds support for XLM-RoBERTa with FlashInfer to Lorax. The XLM-RoBERTa implementation supports embeddings and adapter loading. Changes included in this PR are:

  • added modelling for RoBERTa
  • added XLM-RoBERTa model supporting embeddings and adapter loading
  • added support for adapters in the /embd endpoint (see changes in router and augmented batch in server)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Was this discussed/approved via a Github issue or the discord / slack channel? Please add a link
    to it if that's the case.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@tgaddair

@jfhetzer jfhetzer changed the title Xlm roberta adapter embd Support for Embeddings with XLM-RoBERTa and Adapters Oct 23, 2024
@jfhetzer jfhetzer marked this pull request as ready for review October 23, 2024 10:35
Copy link
Contributor

@tgaddair tgaddair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome! Thanks for the PR @jfhetzer.

I'll do a quick test locally before landing, but LGTM!

@jfhetzer
Copy link
Contributor Author

Thanks for the quick review @tgaddair
Lmk when something pops up in your test!

@tgaddair tgaddair merged commit 3f108f7 into predibase:main Oct 31, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants