Openai embedding endpoint #702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnavgarg1
reviewed
Dec 3, 2024
| ) -> Result<Json<CompatEmbedResponse>, (StatusCode, Json<ErrorResponse>)> { | ||
| metrics::increment_counter!("lorax_request_count"); | ||
| tracing::debug!("Input: {}", req.input); | ||
| if let StringOrVec::Vec(inputs) = req.input { |
There was a problem hiding this comment.
OOC what's the difference between string or vec as inputs? Is it the vec just a list of strings and why we have a .map call?
There was a problem hiding this comment.
yeah but we need to handle the case that the input is a string or a list of strings. Rust is a bit weird like that. So you need a special type for that. https://platform.openai.com/docs/api-reference/embeddings/create#embeddings-create-input
There was a problem hiding this comment.
Very interesting, good to know!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding an OpenAI compatible embedding endpoint.
Also adding a batch embed functionality