-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds support for the Solar architecture #719
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnavgarg1
requested review from
tgaddair,
ajtejankar,
magdyksaleh and
Infernaught
December 16, 2024 17:35
arnavgarg1
commented
Dec 16, 2024
@@ -186,13 +186,16 @@ def from_pb( | |||
if batch_tokenized_inputs is None: | |||
batch_inputs = [] | |||
max_truncation = 0 | |||
for r in pb.requests: | |||
inputs = tokenizers.get_inputs(r, tokenizer) | |||
for request in pb.requests: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated from r
to request
since pdb
treats r
as return so you can't actually inspect this variable.
tgaddair
approved these changes
Dec 16, 2024
magdyksaleh
approved these changes
Dec 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Great stuff @arnavgarg1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Model: https://huggingface.co/upstage/solar-pro-preview-instruct
Output (this model is known to be pretty repetitive):
For the same prompt, from the new
solar-pro-241126
supported on Predibase: