Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable read-only NetCDF DAP uri:s #33

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

juselius
Copy link

Prevent (local) file existence checks for NetCDF uri:s which start with http. Instead pass directly to nc_open_chunked(), to enable read-only DAP/THREDSS support.

@juselius
Copy link
Author

Sorry for modifying white space. My editor removes them, and was too tired to put them back.

@vassilyl
Copy link
Contributor

@juselius, thank you for your interest in contributing to SDSlite. The solution you suggest will prevent treating properly files named http.nc and alike. Can you pls create an issue that documents current behaviour with DAP urls?

@juselius
Copy link
Author

Hi @vassilyl, I'll provide a better solution soon, so that it's done properly. The problem is that I'm quite rusty in C#, since I work mostly in F# on .NET. I already tried to implement a DapUrl property in the URI, but there we so many levels of inheritance and so little time, that I just hacked the FileName property instead to get a working solution.

@juselius juselius force-pushed the master branch 2 times, most recently from 962a750 to b1a12cd Compare February 28, 2022 14:21
@juselius
Copy link
Author

juselius commented Feb 28, 2022

@vassilyl is it better now? I have added a Url property for DAP access to the Uri, and refactored things a bit to avoid duplication.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants