feat(snowflake): add coverage for all common and many exotic Snowflak…

…e data types (#95) Co-authored-by: Scotty Pate <[email protected]>
preendata · Nov 11, 2024 · 5de778f · 5de778f
1 parent 62aca65
commit 5de778f
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 3 deletions.
diff --git a/internal/engine/columns.go b/internal/engine/columns.go
@@ -262,6 +262,7 @@ func processModelColumn(expr *sqlparser.AliasedExpr, cp *columnParser) error {
 	if _, ok := cp.columns[cp.tableName]; !ok {
 		cp.columns[cp.tableName] = make(map[ColumnName]Column)
 	}
+
 	col := Column{
 		TableName: &cp.tableName,
 		Position:  cp.selectIdx,

diff --git a/internal/engine/snowflake.go b/internal/engine/snowflake.go
@@ -110,17 +110,19 @@ func processSnowflakeColumns(rows *sql.Rows) ([]any, error) {
 			valuePtrs[i] = new(duckdbDecimal)
 		case "BIGINT":
 			valuePtrs[i] = new(int64)
+		case "BOOLEAN":
+			valuePtrs[i] = new(bool)
 		case "INT", "MEDIUMINT":
 			valuePtrs[i] = new(int32)
 		case "SMALLINT", "YEAR":
 			valuePtrs[i] = new(int16)
 		case "TINYINT":
 			valuePtrs[i] = new(int8)
-		case "BIT", "BINARY", "VARBINARY", "TINYBLOB", "MEDIUMBLOB", "LONGBLOB", "BLOB":
+		case "BINARY", "VARBINARY", "VARIANT", "OBJECT", "ARRAY":
 			valuePtrs[i] = new([]byte)
-		case "DATE", "DATETIME", "TIMESTAMP", "TIMESTAMP_NTZ":
+		case "DATE", "DATETIME", "TIMESTAMP_TZ", "TIMESTAMP_LTZ", "TIMESTAMP_NTZ":
 			valuePtrs[i] = new(time.Time)
-		case "CHAR", "VARCHAR", "TEXT", "TINYTEXT", "MEDIUMTEXT", "LONGTEXT", "ENUM", "SET", "JSON", "TIME":
+		case "CHAR", "CHARACTER", "NCHAR", "VARCHAR", "TEXT", "STRING", "NVARCHAR", "NVARCHAR2", "CHAR VARYING", "NCHAR VARYING", "ENUM", "SET", "JSON", "TIME":
 			Debug(fmt.Sprintf("Column type is a string: %s", columnType.DatabaseTypeName()))
 			valuePtrs[i] = new(string)
 		default:

diff --git a/internal/engine/types.go b/internal/engine/types.go
@@ -215,6 +215,8 @@ var duckdbTypeMap = map[string]string{
 	"date":                        "date",
 	"timestamp":                   "timestamp",
 	"datetime":                    "timestamp",
+	"timestamp_tz":                "timestamp", //snowflake
+	"timestamp_ltz":               "timestamp", //snowflake
 	"timestamp_ntz":               "timestamp", //snowflake
 	"timestamp without time zone": "timestamp",
 	"timestamp with time zone":    "timestamp",
@@ -225,6 +227,8 @@ var duckdbTypeMap = map[string]string{
 	"mediumblob":                  "blob",
 	"longblob":                    "blob",
 	"bytea":                       "blob",
+	"variant":                     "blob", // snowflake
+	"object":                      "json", // snowflake
 	"json":                        "json",
 	"jsonb":                       "json",
 	"inet":                        "varchar",