Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add --force-reinstall for global install #2275

Conversation

nichmor
Copy link
Contributor

@nichmor nichmor commented Oct 14, 2024

I thought that it would be nice to name it the same as we have it in pixi exec

@nichmor nichmor changed the title feat: add --force-reinstall feat: add --force-reinstall for global install Oct 14, 2024
Copy link
Contributor

@Hofer-Julian Hofer-Julian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

src/cli/global/install.rs Outdated Show resolved Hide resolved
@@ -545,6 +545,45 @@ def test_install_twice(pixi: Path, tmp_path: Path, dummy_channel_1: str) -> None
assert dummy_b.is_file()


def test_install_twice_with_force_reinstall(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could change the default channel in the config after the first install and check that another install does nothing. Then run force reinstall and check that it worked

@nichmor
Copy link
Contributor Author

nichmor commented Oct 15, 2024

as discussed with @Hofer-Julian I will add in the follow-up PR the newer test that will also include this fix:
conda/rattler#900

Copy link
Contributor

@Hofer-Julian Hofer-Julian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed one thing before

tests/integration/test_global.py Outdated Show resolved Hide resolved
tests/integration/test_global.py Outdated Show resolved Hide resolved
Copy link
Contributor

@Hofer-Julian Hofer-Julian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🎉

@Hofer-Julian Hofer-Julian merged commit 66b80c0 into prefix-dev:feature/pixi-global Oct 15, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants