Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: artifactory upload #439

Merged
merged 3 commits into from
Dec 20, 2023
Merged

feat: artifactory upload #439

merged 3 commits into from
Dec 20, 2023

Conversation

0xbe7a
Copy link
Contributor

@0xbe7a 0xbe7a commented Dec 20, 2023

This also includes a small change to the upload CLI interface, as package_name is now a mandatory field and no longer an option.

src/upload.rs Outdated Show resolved Hide resolved
@wolfv
Copy link
Member

wolfv commented Dec 20, 2023

What do you think about making package_file global so that it can be set anywhere? I am going to merge this one and rebase my prefix upload PR.

Could be nice to add the progress bars to all of the uploaders

@wolfv wolfv merged commit 11a6756 into prefix-dev:main Dec 20, 2023
11 checks passed
@pavelzw
Copy link
Collaborator

pavelzw commented Dec 20, 2023

I'm not sure the package_file flag makes sense for rattler-build build since it can produce multiple packages when you specify variant files.

@0xbe7a 0xbe7a deleted the artifactory-upload branch December 20, 2023 15:54
@wolfv
Copy link
Member

wolfv commented Dec 21, 2023

@pavelzw nope. But if we declare the option as global it will be attached to all of the subcommands (but not propagated up).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants