fix: reserved word substrings #263
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucascolley
commented
Apr 8, 2025
|
|
||
| RESERVED_WORD = _{ | ||
| If | Then | Else | Elif | Fi | Do | Done | | ||
| (If | Then | Else | Elif | Fi | Done | Do | |
There was a problem hiding this comment.
still a little fragile—"done" needs to be checked for match before "do"
|
Awesome! |
lucascolley
commented
Apr 8, 2025
crates/tests/src/lib.rs
Outdated
| // Test that there is no panic (prefix-dev/shell#256) | ||
| TestBuilder::new() | ||
| .command(r#"find . -name 'platform*'"#) | ||
| .assert_exit_code(1) |
There was a problem hiding this comment.
the exit code can vary between 0 and 1, we just want to test that it doesn't panic. Not sure how best to do that in this framework
There was a problem hiding this comment.
You could use a non existing command and check whether it's a parse error or command not found?
Like finotexists bla?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes gh-256