Skip to content

fix: allow , in unquoted words #264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 2, 2025
Merged

fix: allow , in unquoted words #264

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion crates/deno_task_shell/src/grammar.pest
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ EXIT_STATUS = ${ "$?" }
// Operators
OPERATOR = _{
AND_IF | OR_IF | DSEMI | DLESS | DGREAT | LESSAND | GREATAND | LESSGREAT | DLESSDASH | CLOBBER |
"," |"(" | ")" | "{" | "}" | ";" | "&" | "|" | "<" | ">"
"(" | ")" | "{" | "}" | ";" | "&" | "|" | "<" | ">"
Copy link
Contributor Author

@lucascolley lucascolley Apr 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@prsabahrami do you happen to know whether there is any behaviour which relies on , being an OPERATOR? At least it doesn't look like there is test coverage for such behaviour.

}

// Reserved words
Expand Down
11 changes: 11 additions & 0 deletions crates/tests/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1479,6 +1479,17 @@ async fn test_reserved_substring() {
.await;
}

#[tokio::test]
async fn test_comma_unquoted() {
// Allow `,` in unquoted words
TestBuilder::new()
.command("echo a,b,c")
.assert_exit_code(0)
.assert_stdout("a,b,c\n")
.run()
.await;
}

#[cfg(test)]
fn no_such_file_error_text() -> &'static str {
if cfg!(windows) {
Expand Down
Loading