forked from KhronosGroup/UnityGLTF
-
Notifications
You must be signed in to change notification settings - Fork 41
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
1 parent
a4e144b
commit ca9cebb
Showing
3 changed files
with
12 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -159,3 +159,4 @@ TestProjects/*/Temp/ | |
| .vscode/ | ||
| TestProjects/*/*.sln | ||
| TestProjects/*/*.csproj | ||
| GLTFSerialization/.idea | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,6 +4,12 @@ All notable changes to this package will be documented in this file. | |
| The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/) | ||
| and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html). | ||
|
|
||
| ## [1.0.4-preview.8] - 2020-09-10 | ||
| - built GLTFSerialization.dll against Newtonsoft.JSON 12.0.3 | ||
| - removed Newtonsoft.JSON.dll from package | ||
| - added dependency on [email protected] | ||
| - added 2020.2 compatibility | ||
|
|
||
| ## [1.0.4-preview.7] - 2020-07-24 | ||
| - fix sRGB/linear conversion for normal maps depending on Unity color space | ||
|
|
||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ca9cebbThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this fork still require Linear Colorspaces or are Gamma Colorspaces supported too?
ca9cebbThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Depends on your render pipeline and type of materials you're using - linear vs. gamma is still an area that I have to finalize work on. I fixed a number of issues that were on the original though. If you find specific issues it would be great if you raise them here so I can address them directly.
ca9cebbThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hybridherbst I've just been looking around UnityGLTF's network to see what other users have patched: https://github.com/KhronosGroup/UnityGLTF/network Found a lot of potential patches in there and added KHR_extensions
ca9cebbThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah it's quite sad that nobody seems to care for the main branch and PRs and people do a lot of redundant work. I stopped creating PRs for the time being since there's no reaction anyways.
I think the biggest improvements in this fork are
ca9cebbThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hybridherbst In regards to particular issues that were never merged in. It might be nice to pull from these branches if you haven't fixed these issues already:
SpecularGlossiness Fix KhronosGroup/UnityGLTF#606
KHR_materials_pbrSpecularGlossiness export support KhronosGroup/UnityGLTF#563
Implemented support for KHR_materials_unlit extension KhronosGroup/UnityGLTF#605
Don`t export primitives if the MeshRenderer or SkinnedMeshRenderer is disabled. KhronosGroup/UnityGLTF#570
Dispose of image streams in AssetCache KhronosGroup/UnityGLTF#581
Change flip texture coordinates with flip texture KhronosGroup/UnityGLTF#562
Also, allowing issues on your fork by manually enabling them in settings would be great so I don't have to comment on commits directly :) @hybridherbst
ca9cebbThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I opened a few PRs into the fork, although Github made it rather difficult. Had to modify the URL for opening the PR to get it to properly target the fork as the destination for the PR.
ca9cebbThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, I enabled Issues! Thanks to pointing me towards that :)
ca9cebbThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hybridherbst Please merge in the PRs when you get a chance. 👍
ca9cebbThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll try, but not sure when I'll get to it;
if you have the capability and want to accelerate this then feel free to try merging them in in your fork and do PRs with fixes if necessary.