Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SVG support for graph #108

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

SVG support for graph #108

wants to merge 1 commit into from

Conversation

ifedor
Copy link

@ifedor ifedor commented Oct 20, 2017

That branch needed to supporting graph images in .svg format

@aik099
Copy link
Collaborator

aik099 commented Oct 20, 2017

I don't understand what the change is for (you haven't provided description in the PR).

@ifedor
Copy link
Author

ifedor commented Nov 10, 2017

I'm sorry for that. "description" already fixed.

@aik099
Copy link
Collaborator

aik099 commented Nov 10, 2017

Still not getting it, sorry. What does it change in UI or how it's affecting any existing logic?

@ifedor
Copy link
Author

ifedor commented Nov 10, 2017

Now you can set .svg format here
to get svg graph instead png or other in page /callgraph.php

@aik099
Copy link
Collaborator

aik099 commented Nov 10, 2017

Then a line above https://github.com/preinheimer/xhprof/blob/master/xhprof_html/callgraph.php#L59 should be updated as well to include SVG.

Any way to change format of call graph to SVG from config (see https://github.com/preinheimer/xhprof/blob/master/xhprof_lib/config.sample.php)?

What benefits do you get from seeing call graph in svg vs png? I bet you can't really zoom-in or something like that or can you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants