Ebean refactor portugal #24

JoaoRoxoNeves · 2017-10-04T16:06:08Z

Created a new module: billy-portugal-ebean

ajcamilo · 2017-10-07T22:42:33Z

...a/com/premiumminds/billy/portugal/persistence/dao/ebean/AbstractDAOPTGenericInvoiceImpl.java

-        return null;
+        JPAGenericInvoiceEntity invoice = this.queryInvoice(uidBusiness.toString(), number).findOne();
+        if (!(invoice instanceof PTGenericInvoiceEntity)) {
+            return null;


I think the previous code returned NoResultException and now returns null

Is this what we want?

The previous code queried PTGenericInvoiceEntities, and then checked if the invoice obtained was a PTGenericInvoiceEntity... if not it would throw a RuntimeException. In practice, that should never happen.
Due to the Ebean inheritance limitations, the new code has to query GenericInvoiceEntities (the superclass). So, after querying, the new code needs to check manually if the invoice is of the right class. In practice, it will always be the right class because the only subclass is the PTGenericInvoiceEntity.

I changed the code to throw a RuntimeException in this case, since it's something that should not happen.

ajcamilo · 2017-10-07T22:45:17Z

...ain/java/com/premiumminds/billy/portugal/persistence/dao/ebean/DAOPTCreditNoteEntryImpl.java

-                if (cnee.getReference().getNumber().compareTo(invoice.getNumber()) == 0) {
-                    return cne;
+        for (JPAPTCreditNoteEntity creditNote : creditNotes) {
+            for (PTCreditNoteEntry entry : creditNote.getEntries()) {


😢

this pulls all the credit notes from the DB and then finds which is from that invoice.

This is terrible

PS: I know the previous code did the same, but I think it is a mistake not to fix this on ebean version.

I tried to translate this to Ebean query beans, but due to its inheritance limitations, it's even harder to do so than translating to hibernate queries...

This is terrible indeed. It is a good example of how extremely valuable bidirectional relations can be. The root of the problem is that the relation between a CreditNoteEntry and its referenced PTInvoice is unidirectional. If it were bidirectional, one could simply obtain only the CreditNoteEntries referencing a certain PTInvoice by using the invoice object itself; not a single query needed.

Anyway, I believe that it would be time-consuming to transform this code, and at this point in time there are other priorities.

Add a TODO please, in order to address this later.

The code already had a TODO. I created an issue for this: #25

ajcamilo · 2017-10-07T22:47:43Z

...src/main/java/com/premiumminds/billy/portugal/persistence/dao/ebean/DAOPTCreditNoteImpl.java

-        return null;
+    public List<PTCreditNoteEntity> getBusinessCreditNotesForSAFTPT(UID businessUid, Date from, Date to) {
+        List<JPAGenericInvoiceEntity> invoices =
+                this.queryInvoice().business.uid.eq(businessUid.toString()).date.between(from, to).findList();


This "between" works the same way as the querydsl? Is all inclusive? just the from?

Yes, it works the same. Both are all inclusive.

In Ebean:
https://github.com/ebean-orm/ebean/blob/331f49824f7b6b555eb980749b676be6a9d7beb1/src/main/java/io/ebeaninternal/server/expression/BetweenExpression.java#L32

In querydsl:
http://grepcode.com/file/repo1.maven.org/maven2/com.querydsl/querydsl-core/4.0.0/com/querydsl/core/types/dsl/ComparableExpression.java#77

ajcamilo · 2017-10-07T22:51:04Z

...src/main/java/com/premiumminds/billy/portugal/persistence/dao/ebean/DAOPTCreditNoteImpl.java

-        /*QJPAPTCreditNoteEntity creditNote = QJPAPTCreditNoteEntity.jPAPTCreditNoteEntity;
-        QJPAPTCreditNoteEntryEntity entry = QJPAPTCreditNoteEntryEntity.jPAPTCreditNoteEntryEntity;
-        QJPAPTGenericInvoiceEntity invoice = QJPAPTGenericInvoiceEntity.jPAPTGenericInvoiceEntity;
+        JPAGenericInvoiceEntity invoice = this.queryInvoice().uid.eq(uidInvoice.toString()).findOne();


don't you need to be aware of nulls here?

The previous code did not check for nulls because it (incorrectly) tried to obtain a list of invoices from this query, which can actually only return 1 object max. Now, the query only obtains a single object.
Before, finding no results would lead to an empty list being returned. I've changed the new code to do the same; return an empty list if no result is found (the invoice is null).

… which are not used by Ebean. Updated .gitignore

- Renamed project to billy-portugal-ebean - Removed dependencies to hibernate and querydsl - Added dependencies to ebean and query bean generator - Updated dependency to maven-compiler-plugin - Adapted build plugins to ebean

…yManager, which is no longer needed

…roject compiles

…bean classes

@transactional

…ated to Ebean's @transactional later

…TEntity class so that the Ebean query bean generator can generate QAssociationsEntities

…an, that has its own automatic DDL generator.

… class, an exception is thrown (instead of returning null)

…is found, an empty list is returned, instead of a NullPointerException

… to be enchanced.

…tion to all entities, so that they can be overridden in modules that extend billy-core-ebean

… from billy-core-ebean

…nceDependencyModule which needed hibernate. Removed generic address, contact, and customer objects that cannot be created alone in Ebean.

…datory(...) to avoid weird linkage error in runtime (ClassCastExceptions)

… bidirectional. This avoids ownership limitation problem of Ebean http://ebean-orm.github.io/docs/mapping/jpa/oneToMany

…y bidirectional. This avoids ownership limitation problem of Ebean http://ebean-orm.github.io/docs/mapping/jpa/oneToMany

…relations to aboid problems with Ebean generating random column names

… instead of handling the injector directly

… zero-valued taxes

… to @manytoone. This allows several entries of a credit note to reference the same invoice multiple times.

… taxes

…ayments is no longer required

ajcamilo · 2017-11-21T20:32:54Z

...-ebean/src/main/java/com/premiumminds/billy/portugal/persistence/dao/ebean/DAOPTTaxImpl.java

-            ptTaxes.addAll(taxContextResult);
+        List<JPAPTRegionContextEntity> childContexts = this.getChildContexts(context);
+        for (JPAPTRegionContextEntity childContext : childContexts) {
+            ptTaxes.addAll(this.getTaxesForSAFTPT(childContext, validFrom, validTo));


Does this new code do the same as the old one? Can you explain what happened here?

The old code was over-engineered and, as a result, had a bug that prevented adding taxes from sub-contexts where a parent context did not have any tax associated. This simpler version solves that bug.

…ented all the tests that need to be refactored later.

JoaoRoxoNeves requested review from mabrcosta, miroxo and ajcamilo October 4, 2017 16:06

ajcamilo reviewed Oct 10, 2017

View reviewed changes

João Neves added 23 commits October 23, 2017 17:44

Created billy-portugal-ebean as a copy of billy-portugal

e5ffd19

Removed unnecessary javadoc. Removed orm-core.xml and persistence.xml…

b6ffb7b

… which are not used by Ebean. Updated .gitignore

In pom.xml:

529842e

- Renamed project to billy-portugal-ebean - Removed dependencies to hibernate and querydsl - Added dependencies to ebean and query bean generator - Updated dependency to maven-compiler-plugin - Adapted build plugins to ebean

Removed all references to hibernate.envers @Audited

9b01f80

Removed @Inheritance JOINED because it is not supported by Ebean

d1ae0a1

Removed from all DAOs the constructor that provided hibernation Entit…

fe70cde

…yManager, which is no longer needed

Commented all the hibernate-query code to translate later, once the p…

f7d37bc

…roject compiles

[billy-gin] Changed dependency from billy-core-jpa to billy-core

4a4bac0

Changed all import packages of billy-core-jpa classes to billy-core-e…

45484a4

…bean classes

Removed useless @OverRide that was the cause of compilation problems.

375df4a

Updated the Copyright header of all source files

02072e9

Commented EntityManager calls in several tests that need to be transl…

6ac5a47

…ated to Ebean's @transactional later

Changed package declarations from jpa to ebean

0fbcd67

Changed the type of a @OnetoOne relation to link to the concrete JPAP…

75b60bf

…TEntity class so that the Ebean query bean generator can generate QAssociationsEntities

Translated all previously-commented JPA queries to Ebean query beans

fe68e26

Updated VAT values and time period to 2017-2018

b9a45d7

Removed SchemaExport DDL generator which is no longer needed with Ebe…

d56fa0c

…an, that has its own automatic DDL generator.

When finding a generic invoice, if the instance found is of the wrong…

7f84335

… class, an exception is thrown (instead of returning null)

When finding the credit notes referencing a document, if no document …

d50bf1f

…is found, an empty list is returned, instead of a NullPointerException

Added missing ebean.mf with the entity & querybean packages that need…

32b95ab

… to be enchanced.

[billy-core-ebean] Added @Inheritance and @DiscriminatorColumn annota…

aca99af

…tion to all entities, so that they can be overridden in modules that extend billy-core-ebean

@DiscriminatorValue annotation to all entities, which extend entities…

608bc1d

… from billy-core-ebean

Added missing package property to ebean.mf

e274a48

JoaoRoxoNeves force-pushed the ebeanRefactor-Portugal branch from 7f54273 to e274a48 Compare October 23, 2017 16:45

Removed from PortugalBootstrap the initialization of PortugalPErsiste…

91ea678

…nceDependencyModule which needed hibernate. Removed generic address, contact, and customer objects that cannot be created alone in Ebean.

JoaoRoxoNeves force-pushed the ebeanRefactor-Portugal branch from 5c89525 to 91ea678 Compare October 25, 2017 13:42

ajcamilo changed the title ~~Ebean refactor portugal~~ WIP: Ebean refactor portugal Oct 27, 2017

Added generic specifications to all invocations of BillyValidator.man…

f30e559

…datory(...) to avoid weird linkage error in runtime (ClassCastExceptions)

JoaoRoxoNeves force-pushed the ebeanRefactor-Portugal branch from 097e9d5 to f30e559 Compare October 27, 2017 15:05

João Neves added 4 commits October 27, 2017 17:15

Made the relations between Customer and Address, Supplier and Address…

04560df

… bidirectional. This avoids ownership limitation problem of Ebean http://ebean-orm.github.io/docs/mapping/jpa/oneToMany

[billy-core-ebean] Made the @onetomany relations to the Contact entit…

a105acc

…y bidirectional. This avoids ownership limitation problem of Ebean http://ebean-orm.github.io/docs/mapping/jpa/oneToMany

[billy-core-ebean] Added @joincolumn to all unidireccional @onetomany …

475ae43

…relations to aboid problems with Ebean generating random column names

Services.java and PersistenceServices.java now use @Inject annotation…

77d656a

… instead of handling the injector directly

JoaoRoxoNeves force-pushed the ebeanRefactor-Portugal branch from 0986139 to 77d656a Compare November 15, 2017 10:56

João Neves added 6 commits November 15, 2017 18:14

Corrected a bug in the GenericInvoiceBuilderImpl that prevented using…

24668cd

… zero-valued taxes

Changed the relation of the CreditNoteEntry to the referenced Invoice…

985fe39

… to @manytoone. This allows several entries of a credit note to reference the same invoice multiple times.

Corrected a problem with comparing BigDecimals with ZERO in regard to…

50c37e1

… taxes

[billy-core] Added a new field to the InvoiceEntry: taxExemptionCode

1b782e9

Corrected a problem a query of DAOPTTaxImpl which was returning no taxes

3cf3787

[billy-portugal] When building a GenericInvoice, having one or more p…

2db48b2

…ayments is no longer required

ajcamilo reviewed Nov 21, 2017

View reviewed changes

ajcamilo changed the title ~~WIP: Ebean refactor portugal~~ Ebean refactor portugal Nov 23, 2017

[billy-portugal-ebean] Added the module to billy's main pom.xml. Comm…

70c7ba8

…ented all the tests that need to be refactored later.

ajcamilo merged commit 5a6c5b1 into premium-minds:master Nov 27, 2017

JoaoRoxoNeves deleted the ebeanRefactor-Portugal branch January 10, 2018 18:23

froque added the ebean label Jan 11, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Ebean refactor portugal #24

Ebean refactor portugal #24

JoaoRoxoNeves commented Oct 4, 2017

ajcamilo Oct 7, 2017

JoaoRoxoNeves Oct 16, 2017 •

edited

Loading

ajcamilo Oct 7, 2017

JoaoRoxoNeves Oct 16, 2017 •

edited

Loading

ajcamilo Oct 16, 2017

JoaoRoxoNeves Oct 16, 2017

ajcamilo Oct 7, 2017

JoaoRoxoNeves Oct 16, 2017

ajcamilo Oct 7, 2017

JoaoRoxoNeves Oct 16, 2017 •

edited

Loading

ajcamilo Nov 21, 2017

JoaoRoxoNeves Nov 22, 2017

Ebean refactor portugal #24

Ebean refactor portugal #24

Conversation

JoaoRoxoNeves commented Oct 4, 2017

Choose a reason for hiding this comment

JoaoRoxoNeves Oct 16, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

JoaoRoxoNeves Oct 16, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

JoaoRoxoNeves Oct 16, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

JoaoRoxoNeves Oct 16, 2017 •

edited

Loading

JoaoRoxoNeves Oct 16, 2017 •

edited

Loading

JoaoRoxoNeves Oct 16, 2017 •

edited

Loading