don't get user if id is None

preset-io · Dec 22, 2023 · c681637 · c681637
1 parent 59d8703
commit c681637
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/superset/tasks/async_queries.py b/superset/tasks/async_queries.py
@@ -112,10 +112,10 @@ def load_explore_json_into_cache(  # pylint: disable=too-many-locals
 ) -> None:
     cache_key_prefix = "ejr-"  # ejr: explore_json request
 
-    user = (
-        security_manager.get_user_by_id(job_metadata.get("user_id"))
-        or security_manager.get_anonymous_user()
-    )
+    if user_id := job_metadata.get("user_id"):
+        user = security_manager.get_user_by_id(user_id)
+    else:
+        user = security_manager.get_anonymous_user()
 
     with override_user(user, force=False):
         try: