Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump fetch-retry from 4.1.1 to 5.0.6 in /superset-frontend/packages/superset-ui-core #803

Conversation

dependabot[bot]
Copy link

@dependabot dependabot bot commented on behalf of github Jan 12, 2024

Bumps fetch-retry from 4.1.1 to 5.0.6.

Release notes

Sourced from fetch-retry's releases.

Type definition of the defaults parameter

Adds type definition for the defaults parameter in the fetchBuilder function. Previously it was mistakenly typed as object which was not very helpful.

Many thanks to @​simeonborko for reporting the issue and providing the PR.

Fix type definition to support URL instance

Fixes a bug where URL instances could not be passed as the first argument to the wrapped fetch function.

Many thanks to @​afmelsaidy for reporting the issue and providing a pull request.

Adds example on how to use with Node.js fetch and fixes failing tests

  • Adds an example on how to use with Node.js fetch API which became available in version 18.
  • Fixes failing tests when running Node.js version 18, which failed due to using an older version of node-fetch, resulting in having multiple versions of the Request object.

Security updates: minimist

Updated dependencies and fixed security issues reported in dependencies, most notably minimist.

Bug fixes and security fixes

  • @​pwambach fixed an issue where typescript definition no longer was valid. The fix was to use a default export instead.
  • @​bamse16 fixed an issue where npm install for production and ci would fail due to husky being defined as a dev dependency
  • Security fixes, including a high severity issue for node-fetch.

Thanks for all the contributions, and apologies for taking a long time to merge the fixes.

Bug fix for node environment

Fixes a bug (#63) introduced in version 5.0.0 where support for the Request argument was added. The initial implementation introduced a runtime error for the node environment.

Many thanks to @​paulrosania for reporting the issue, and to @​knotthere for creating a PR with the suggested fix.

Improvements and bug fix

This release includes a bundle of improvements and a bug fix. Due to the renaming of the IRequestInitWithRetry interface, I have created a new major release to attempt to mitigate any potential breaking changes.

Included in this release:

  • Rename IRequestInitWithRetry to RequestInitWithRetry and export the interface (@​christophehurpeau)
  • Use rollup.js to support UMD builds (@​dwiyatci)
  • Adding support for Request argument (@​knotthere)
  • Added integration tests for Request argument and URL type (@​jonbern)
  • Added husky pre-commit script to build project and run tests (@​jonbern)
  • Upgrade dependencies to fix security warnings

Many thanks for all the contributions for improving this project. It is greatly appreciated! 🙏

Commits
  • 228661e 5.0.6
  • 0c1dce6 keep RequestInitRetryParams type public to avoid potential breaking change
  • 74d8001 Merge pull request #87 from simeonborko/master
  • abdf562 Type definition of the defaults parameter
  • 7023d68 5.0.5
  • 14ed6fd Merge pull request #84 from afmelsaidy/master
  • 6d0fbf3 Fix type definition to allow passing URL or RequestInfo
  • f375c70 5.0.4
  • 72b5a5c adds build status badge (GitHub actions)
  • 2ed3d78 Merge pull request #83 from jonbern/feat/node_native_fetch
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [fetch-retry](https://github.com/jonbern/fetch-retry) from 4.1.1 to 5.0.6.
- [Release notes](https://github.com/jonbern/fetch-retry/releases)
- [Commits](jonbern/fetch-retry@4.1.1...5.0.6)

---
updated-dependencies:
- dependency-name: fetch-retry
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Copy link
Author

dependabot bot commented on behalf of github Jan 12, 2024

The following labels could not be found: npm, dependabot, plugins.

@codecov-commenter
Copy link

codecov-commenter commented Jan 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b98d4b4) 69.16% compared to head (d10e728) 82.86%.

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #803       +/-   ##
===========================================
+ Coverage   69.16%   82.86%   +13.69%     
===========================================
  Files        1948      520     -1428     
  Lines       76062    36541    -39521     
  Branches     8493        0     -8493     
===========================================
- Hits        52609    30278    -22331     
+ Misses      21273     6263    -15010     
+ Partials     2180        0     -2180     
Flag Coverage Δ
hive 53.68% <ø> (ø)
javascript ?
mysql 78.06% <ø> (ø)
postgres 78.16% <ø> (ø)
presto 53.63% <ø> (ø)
python 82.86% <ø> (ø)
sqlite 77.75% <ø> (ø)
unit 55.89% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Author

dependabot bot commented on behalf of github Jan 24, 2024

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the 6c11dependabot/npm_and_yarn/superset-frontend/packages/superset-ui-core/fetch-retry-5.0.6 branch January 24, 2024 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants