Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: mathjax-3 #103

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from
Open

feat: mathjax-3 #103

wants to merge 4 commits into from

Conversation

arzola
Copy link

@arzola arzola commented Feb 13, 2025

This pull request includes significant updates to the MathJax integration and various code simplifications in the src/imageGenerator.js file. The most important changes are listed below:

MathJax Integration Update:

  • Replaced mathjax-node with mathjax-full for better performance and more features. Updated the package.json to reflect this change.
  • Refactored the MathJax initialization and configuration to use the new mathjax-full components (TeX, SVG, liteAdaptor, RegisterHTMLHandler).

Code Simplifications:

  • Simplified the inArray function by replacing it with the Array.prototype.includes method.
  • Improved the isValidColor function by using a more concise regular expression test.
  • Removed unnecessary comments and redundant code, streamlining the generate function for better readability and maintainability.

@pkra
Copy link

pkra commented Feb 14, 2025

Just a random note that MathJax v4 has been in beta for over a year. Depending on your timeline (and theirs), it might be worth skipping v3.

@arzola
Copy link
Author

arzola commented Feb 17, 2025

Hey @pkra thank you for your feedback, we appreciate that a lot we are planning to release this new version next sprint ~2 weeks, but we will open an experimental branch with the beta version to start testing our libraries with that version in parallel

@pkra
Copy link

pkra commented Feb 18, 2025

@arzola no worries. I realize how random my comment was. I helped pb with some questions years ago (when I was still working for MathJax) and I was still subscribed to the repository.

@arzola
Copy link
Author

arzola commented Feb 18, 2025

@pkra not problem at all, in fact we truly appreciate your input, we want to provide good support for tons of different math notations and modules

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants