Cleanup code formatting #11726
Merged
Cleanup code formatting #11726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kokosing
reviewed
Oct 17, 2018
| @@ -51,9 +51,9 @@ public boolean equals(Object other) | |||
| } | |||
|
|
|||
| BingTile otherTile = (BingTile) other; | |||
| return this.x == otherTile.x | |||
| && this.y == otherTile.y | |||
| && this.zoomLevel == otherTile.zoomLevel; | |||
There was a problem hiding this comment.
can we write a style for that?
There was a problem hiding this comment.
Looks like we can: http://checkstyle.sourceforge.net/config_whitespace.html#OperatorWrap
There was a problem hiding this comment.
Filed airlift/airbase#158
| @@ -25,7 +25,8 @@ | |||
| public class TestConsoleHistory | |||
| { | |||
| @Test | |||
| public void testNonExistingHomeFolder() throws Exception | |||
| public void testNonExistingHomeFolder() | |||
| throws Exception | |||
There was a problem hiding this comment.
can we write a style for that?
There was a problem hiding this comment.
I've been unable to find a Checkstyle rule for that. I wish it could do that.
There was a problem hiding this comment.
It should be easy to write a regex for that.
There was a problem hiding this comment.
Filed airlift/airbase#160
dain
approved these changes
Oct 18, 2018
kokosing
approved these changes
Oct 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.