Refactor Iceberg Connector #21855
Merged
Refactor Iceberg Connector #21855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yingsu00
approved these changes
Feb 5, 2024
There was a problem hiding this comment.
@imjalpreet Looks good, could you please add a comment in each wrapper class why we added them?
| UPDATE_BEFORE, | ||
| UPDATE_AFTER; | ||
|
|
||
| public static ChangelogOperation fromIcebergChangelogOperation(org.apache.iceberg.ChangelogOperation operation) |
There was a problem hiding this comment.
@yingsu00 We have to use the fully qualified class name since we have used the same enum name in Presto. Please let me know in case you are talking about something else.
imjalpreet
force-pushed
the
refactorIcebergConnector
branch
from
1485f17 to
62ad103
Compare
yingsu00
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add wrappers for certain enums(FileFormat, FileContent, and ChangelogOperation) from Iceberg Library to Presto to simplify the presto protocol generation for Prestissimo
Motivation and Context
Simplify the presto protocol generation for Prestissimo required for #21765
Contributor checklist
Release Notes
Please follow release notes guidelines and fill in the release notes below.