Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iceberg] [native] Introduce Iceberg Connector in Prestissimo (with multi-level inheritance) #21905

Conversation

imjalpreet
Copy link
Member

Description

Introduce presto protocol changes to parse/deserialize Iceberg Plan Fragment and other Iceberg Java objects. We also map the Java Iceberg objects to Velox Hive objects.

Motivation and Context

facebookincubator/velox#5977

Impact

With these changes, we will be able to read iceberg tables from Prestissimo

Test Plan

Successfully ran all TPC-H queries with iceberg tables (both partitioned and non-partitioned)

Contributor checklist

  • Please make sure your submission complies with our development, formatting, commit message, and attribution guidelines.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

Please follow release notes guidelines and fill in the release notes below.

== RELEASE NOTES ==

General Changes
* Introduce Iceberg Connector in Prestissimo

imjalpreet and others added 6 commits February 9, 2024 20:41
Introduce presto protocol changes to parse/deserialize Iceberg Plan Fragment and other Iceberg Java objects
1. Map Java IcebergColumnHandle to Velox HiveColumnHandle
2. Map Java IcebergTableLayoutHandle to Velox HiveTableHandle
Co-authored-by: Jalpreet Singh Nanda (:imjalpreet) <[email protected]>
@imjalpreet imjalpreet self-assigned this Feb 12, 2024
@imjalpreet imjalpreet requested review from a team as code owners February 12, 2024 16:20
@imjalpreet imjalpreet marked this pull request as draft February 12, 2024 16:20
@yingsu00 yingsu00 self-requested a review February 12, 2024 16:21
@yingsu00 yingsu00 added the iceberg Apache Iceberg related label Feb 12, 2024
@tdcmeehan
Copy link
Contributor

Closing as this is not the approach we are taking.

@tdcmeehan tdcmeehan closed this Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
iceberg Apache Iceberg related
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants